Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn

public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed

* Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
       [not found]       ` <CAPcyv4gE0+3pZQV=V75wxddFVhWeAz1abfJ=q8D1Zi+8Oi17rA@mail.gmail.com>
@ 2017-02-07  0:14         ` James Bottomley
  2017-02-07  4:09           ` Jens Axboe
  0 siblings, 1 reply; 6+ messages in thread
From: James Bottomley @ 2017-02-07  0:14 UTC (permalink / raw)
  To: Dan Williams, Christoph Hellwig
  Cc: kernel test robot, Jens Axboe, Bart Van Assche,
	Martin K. Petersen, Jan Kara, Omar Sandoval, Omar Sandoval, LKML,
	Jens Axboe, LKP, linux-scsi, linux-block

On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
> > Dan,
> > 
> > can you please quote your emails?  I can't find any content 
> > inbetween all these quotes.
> 
> Sorry, I'm using gmail, but I'll switch to attaching the logs.
> 
> So with help from Xiaolong I was able to reproduce this, and it does
> not appear to be a regression. We simply change the failure output of
> an existing bug. Attached is a log of the same test on v4.10-rc7 
> (i.e. without the recent block/scsi fixes), and it shows sda being
> registered twice.
> 
> "[    6.647077] kobject (d5078ca4): tried to init an initialized
> object, something is seriously wrong."
> 
> The change that "scsi, block: fix duplicate bdi name registration
> crashes" makes is to properly try to register sdb since the sda devt
> is still alive. However that's not a fix because we've managed to 
> call blk_register_queue() twice on the same queue.

OK, time to involve others: linux-scsi and linux-block cc'd and I've
inserted the log below.

James

---

[    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
[    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.026965] sd 0:0:0:0: [sda] Write Protect is off
[    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.546964] sd 0:0:0:0: [sda] Write Protect is off
[    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
[    6.648723] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.649811] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.651418] Workqueue: events_unbound async_run_entry_fn
[    6.652347] Call Trace:
[    6.652987]  dump_stack+0x79/0xa4
[    6.653716]  kobject_init+0x75/0x90
[    6.654452]  blk_mq_register_dev+0x2a/0x110
[    6.655269]  blk_register_queue+0x7b/0x130
[    6.656080]  device_add_disk+0x1c6/0x460
[    6.656866]  sd_probe_async+0xf1/0x1c0
[    6.657634]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.658501]  async_run_entry_fn+0x30/0x190
[    6.659311]  ? process_one_work+0x12f/0x430
[    6.660113]  process_one_work+0x1aa/0x430
[    6.660901]  ? process_one_work+0x12f/0x430
[    6.661716]  worker_thread+0x1dd/0x470
[    6.662479]  kthread+0xd4/0x100
[    6.663175]  ? process_one_work+0x430/0x430
[    6.663984]  ? __kthread_create_on_node+0x180/0x180
[    6.664869]  ret_from_fork+0x21/0x2c
[    6.665638] kobject (ffab51ec): tried to init an initialized object, something is seriously wrong.
[    6.667290] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.668372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.669984] Workqueue: events_unbound async_run_entry_fn
[    6.670909] Call Trace:
[    6.671540]  dump_stack+0x79/0xa4
[    6.672266]  kobject_init+0x75/0x90
[    6.673011]  blk_mq_register_dev+0x4c/0x110
[    6.673832]  blk_register_queue+0x7b/0x130
[    6.674633]  device_add_disk+0x1c6/0x460
[    6.675413]  sd_probe_async+0xf1/0x1c0
[    6.676191]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.677057]  async_run_entry_fn+0x30/0x190
[    6.677860]  ? process_one_work+0x12f/0x430
[    6.678667]  process_one_work+0x1aa/0x430
[    6.679455]  ? process_one_work+0x12f/0x430
[    6.680269]  worker_thread+0x1dd/0x470
[    6.681036]  kthread+0xd4/0x100
[    6.681737]  ? process_one_work+0x430/0x430
[    6.682540]  ? __kthread_create_on_node+0x180/0x180
[    6.683420]  ret_from_fork+0x21/0x2c
[    6.684207] ------------[ cut here ]------------
[    6.685067] WARNING: CPU: 0 PID: 99 at ./include/linux/kref.h:46 kobject_get+0x7f/0x90
[    6.686592] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.687680] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.689280] Workqueue: events_unbound async_run_entry_fn
[    6.690208] Call Trace:
[    6.690843]  dump_stack+0x79/0xa4
[    6.691563]  __warn+0xd2/0xf0
[    6.692246]  ? kobject_get+0x7f/0x90
[    6.692992]  warn_slowpath_null+0x25/0x30
[    6.693787]  kobject_get+0x7f/0x90
[    6.694505]  kobject_add_internal+0x2e/0x360
[    6.695322]  ? kfree_const+0x18/0x20
[    6.696071]  ? kobject_set_name_vargs+0x62/0x80
[    6.696914]  kobject_add+0x35/0x80
[    6.697642]  blk_mq_register_hctx+0x95/0xc0
[    6.698447]  blk_mq_register_dev+0xc9/0x110
[    6.699255]  blk_register_queue+0x7b/0x130
[    6.700059]  device_add_disk+0x1c6/0x460
[    6.700849]  sd_probe_async+0xf1/0x1c0
[    6.701628]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.702484]  async_run_entry_fn+0x30/0x190
[    6.703284]  ? process_one_work+0x12f/0x430
[    6.704098]  process_one_work+0x1aa/0x430
[    6.704894]  ? process_one_work+0x12f/0x430
[    6.705704]  worker_thread+0x1dd/0x470
[    6.706488]  kthread+0xd4/0x100
[    6.707198]  ? process_one_work+0x430/0x430
[    6.708016]  ? __kthread_create_on_node+0x180/0x180
[    6.708909]  ret_from_fork+0x21/0x2c
[    6.709676] ---[ end trace 1a7726d7c3d3c8d0 ]---
[    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
[    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.026965] sd 0:0:0:0: [sda] Write Protect is off
[    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.546964] sd 0:0:0:0: [sda] Write Protect is off
[    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
[    6.648723] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.649811] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.651418] Workqueue: events_unbound async_run_entry_fn
[    6.652347] Call Trace:
[    6.652987]  dump_stack+0x79/0xa4
[    6.653716]  kobject_init+0x75/0x90
[    6.654452]  blk_mq_register_dev+0x2a/0x110
[    6.655269]  blk_register_queue+0x7b/0x130
[    6.656080]  device_add_disk+0x1c6/0x460
[    6.656866]  sd_probe_async+0xf1/0x1c0
[    6.657634]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.658501]  async_run_entry_fn+0x30/0x190
[    6.659311]  ? process_one_work+0x12f/0x430
[    6.660113]  process_one_work+0x1aa/0x430
[    6.660901]  ? process_one_work+0x12f/0x430
[    6.661716]  worker_thread+0x1dd/0x470
[    6.662479]  kthread+0xd4/0x100
[    6.663175]  ? process_one_work+0x430/0x430
[    6.663984]  ? __kthread_create_on_node+0x180/0x180
[    6.664869]  ret_from_fork+0x21/0x2c
[    6.665638] kobject (ffab51ec): tried to init an initialized object, something is seriously wrong.
[    6.667290] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.668372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.669984] Workqueue: events_unbound async_run_entry_fn
[    6.670909] Call Trace:
[    6.671540]  dump_stack+0x79/0xa4
[    6.672266]  kobject_init+0x75/0x90
[    6.673011]  blk_mq_register_dev+0x4c/0x110
[    6.673832]  blk_register_queue+0x7b/0x130
[    6.674633]  device_add_disk+0x1c6/0x460
[    6.675413]  sd_probe_async+0xf1/0x1c0
[    6.676191]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.677057]  async_run_entry_fn+0x30/0x190
[    6.677860]  ? process_one_work+0x12f/0x430
[    6.678667]  process_one_work+0x1aa/0x430
[    6.679455]  ? process_one_work+0x12f/0x430
[    6.680269]  worker_thread+0x1dd/0x470
[    6.681036]  kthread+0xd4/0x100
[    6.681737]  ? process_one_work+0x430/0x430
[    6.682540]  ? __kthread_create_on_node+0x180/0x180
[    6.683420]  ret_from_fork+0x21/0x2c
[    6.684207] ------------[ cut here ]------------
[    6.685067] WARNING: CPU: 0 PID: 99 at ./include/linux/kref.h:46 kobject_get+0x7f/0x90
[    6.686592] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.687680] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.689280] Workqueue: events_unbound async_run_entry_fn
[    6.690208] Call Trace:
[    6.690843]  dump_stack+0x79/0xa4
[    6.691563]  __warn+0xd2/0xf0
[    6.692246]  ? kobject_get+0x7f/0x90
[    6.692992]  warn_slowpath_null+0x25/0x30
[    6.693787]  kobject_get+0x7f/0x90
[    6.694505]  kobject_add_internal+0x2e/0x360
[    6.695322]  ? kfree_const+0x18/0x20
[    6.696071]  ? kobject_set_name_vargs+0x62/0x80
[    6.696914]  kobject_add+0x35/0x80
[    6.697642]  blk_mq_register_hctx+0x95/0xc0
[    6.698447]  blk_mq_register_dev+0xc9/0x110
[    6.699255]  blk_register_queue+0x7b/0x130
[    6.700059]  device_add_disk+0x1c6/0x460
[    6.700849]  sd_probe_async+0xf1/0x1c0
[    6.701628]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.702484]  async_run_entry_fn+0x30/0x190
[    6.703284]  ? process_one_work+0x12f/0x430
[    6.704098]  process_one_work+0x1aa/0x430
[    6.704894]  ? process_one_work+0x12f/0x430
[    6.705704]  worker_thread+0x1dd/0x470
[    6.706488]  kthread+0xd4/0x100
[    6.707198]  ? process_one_work+0x430/0x430
[    6.708016]  ? __kthread_create_on_node+0x180/0x180
[    6.708909]  ret_from_fork+0x21/0x2c
[    6.709676] ---[ end trace 1a7726d7c3d3c8d0 ]---
[    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
[    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.026965] sd 0:0:0:0: [sda] Write Protect is off
[    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.546964] sd 0:0:0:0: [sda] Write Protect is off
[    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
[    6.648723] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.649811] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.651418] Workqueue: events_unbound async_run_entry_fn
[    6.652347] Call Trace:
[    6.652987]  dump_stack+0x79/0xa4
[    6.653716]  kobject_init+0x75/0x90
[    6.654452]  blk_mq_register_dev+0x2a/0x110
[    6.655269]  blk_register_queue+0x7b/0x130
[    6.656080]  device_add_disk+0x1c6/0x460
[    6.656866]  sd_probe_async+0xf1/0x1c0
[    6.657634]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.658501]  async_run_entry_fn+0x30/0x190
[    6.659311]  ? process_one_work+0x12f/0x430
[    6.660113]  process_one_work+0x1aa/0x430
[    6.660901]  ? process_one_work+0x12f/0x430
[    6.661716]  worker_thread+0x1dd/0x470
[    6.662479]  kthread+0xd4/0x100
[    6.663175]  ? process_one_work+0x430/0x430
[    6.663984]  ? __kthread_create_on_node+0x180/0x180
[    6.664869]  ret_from_fork+0x21/0x2c
[    6.665638] kobject (ffab51ec): tried to init an initialized object, something is seriously wrong.
[    6.667290] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.668372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.669984] Workqueue: events_unbound async_run_entry_fn
[    6.670909] Call Trace:
[    6.671540]  dump_stack+0x79/0xa4
[    6.672266]  kobject_init+0x75/0x90
[    6.673011]  blk_mq_register_dev+0x4c/0x110
[    6.673832]  blk_register_queue+0x7b/0x130
[    6.674633]  device_add_disk+0x1c6/0x460
[    6.675413]  sd_probe_async+0xf1/0x1c0
[    6.676191]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.677057]  async_run_entry_fn+0x30/0x190
[    6.677860]  ? process_one_work+0x12f/0x430
[    6.678667]  process_one_work+0x1aa/0x430
[    6.679455]  ? process_one_work+0x12f/0x430
[    6.680269]  worker_thread+0x1dd/0x470
[    6.681036]  kthread+0xd4/0x100
[    6.681737]  ? process_one_work+0x430/0x430
[    6.682540]  ? __kthread_create_on_node+0x180/0x180
[    6.683420]  ret_from_fork+0x21/0x2c
[    6.684207] ------------[ cut here ]------------
[    6.685067] WARNING: CPU: 0 PID: 99 at ./include/linux/kref.h:46 kobject_get+0x7f/0x90
[    6.686592] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.687680] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.689280] Workqueue: events_unbound async_run_entry_fn
[    6.690208] Call Trace:
[    6.690843]  dump_stack+0x79/0xa4
[    6.691563]  __warn+0xd2/0xf0
[    6.692246]  ? kobject_get+0x7f/0x90
[    6.692992]  warn_slowpath_null+0x25/0x30
[    6.693787]  kobject_get+0x7f/0x90
[    6.694505]  kobject_add_internal+0x2e/0x360
[    6.695322]  ? kfree_const+0x18/0x20
[    6.696071]  ? kobject_set_name_vargs+0x62/0x80
[    6.696914]  kobject_add+0x35/0x80
[    6.697642]  blk_mq_register_hctx+0x95/0xc0
[    6.698447]  blk_mq_register_dev+0xc9/0x110
[    6.699255]  blk_register_queue+0x7b/0x130
[    6.700059]  device_add_disk+0x1c6/0x460
[    6.700849]  sd_probe_async+0xf1/0x1c0
[    6.701628]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.702484]  async_run_entry_fn+0x30/0x190
[    6.703284]  ? process_one_work+0x12f/0x430
[    6.704098]  process_one_work+0x1aa/0x430
[    6.704894]  ? process_one_work+0x12f/0x430
[    6.705704]  worker_thread+0x1dd/0x470
[    6.706488]  kthread+0xd4/0x100
[    6.707198]  ? process_one_work+0x430/0x430
[    6.708016]  ? __kthread_create_on_node+0x180/0x180
[    6.708909]  ret_from_fork+0x21/0x2c
[    6.709676] ---[ end trace 1a7726d7c3d3c8d0 ]---
[    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
[    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.026965] sd 0:0:0:0: [sda] Write Protect is off
[    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.546964] sd 0:0:0:0: [sda] Write Protect is off
[    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
[    6.648723] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.649811] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.651418] Workqueue: events_unbound async_run_entry_fn
[    6.652347] Call Trace:
[    6.652987]  dump_stack+0x79/0xa4
[    6.653716]  kobject_init+0x75/0x90
[    6.654452]  blk_mq_register_dev+0x2a/0x110
[    6.655269]  blk_register_queue+0x7b/0x130
[    6.656080]  device_add_disk+0x1c6/0x460
[    6.656866]  sd_probe_async+0xf1/0x1c0
[    6.657634]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.658501]  async_run_entry_fn+0x30/0x190
[    6.659311]  ? process_one_work+0x12f/0x430
[    6.660113]  process_one_work+0x1aa/0x430
[    6.660901]  ? process_one_work+0x12f/0x430
[    6.661716]  worker_thread+0x1dd/0x470
[    6.662479]  kthread+0xd4/0x100
[    6.663175]  ? process_one_work+0x430/0x430
[    6.663984]  ? __kthread_create_on_node+0x180/0x180
[    6.664869]  ret_from_fork+0x21/0x2c
[    6.665638] kobject (ffab51ec): tried to init an initialized object, something is seriously wrong.
[    6.667290] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.668372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.669984] Workqueue: events_unbound async_run_entry_fn
[    6.670909] Call Trace:
[    6.671540]  dump_stack+0x79/0xa4
[    6.672266]  kobject_init+0x75/0x90
[    6.673011]  blk_mq_register_dev+0x4c/0x110
[    6.673832]  blk_register_queue+0x7b/0x130
[    6.674633]  device_add_disk+0x1c6/0x460
[    6.675413]  sd_probe_async+0xf1/0x1c0
[    6.676191]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.677057]  async_run_entry_fn+0x30/0x190
[    6.677860]  ? process_one_work+0x12f/0x430
[    6.678667]  process_one_work+0x1aa/0x430
[    6.679455]  ? process_one_work+0x12f/0x430
[    6.680269]  worker_thread+0x1dd/0x470
[    6.681036]  kthread+0xd4/0x100
[    6.681737]  ? process_one_work+0x430/0x430
[    6.682540]  ? __kthread_create_on_node+0x180/0x180
[    6.683420]  ret_from_fork+0x21/0x2c
[    6.684207] ------------[ cut here ]------------
[    6.685067] WARNING: CPU: 0 PID: 99 at ./include/linux/kref.h:46 kobject_get+0x7f/0x90
[    6.686592] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.687680] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.689280] Workqueue: events_unbound async_run_entry_fn
[    6.690208] Call Trace:
[    6.690843]  dump_stack+0x79/0xa4
[    6.691563]  __warn+0xd2/0xf0
[    6.692246]  ? kobject_get+0x7f/0x90
[    6.692992]  warn_slowpath_null+0x25/0x30
[    6.693787]  kobject_get+0x7f/0x90
[    6.694505]  kobject_add_internal+0x2e/0x360
[    6.695322]  ? kfree_const+0x18/0x20
[    6.696071]  ? kobject_set_name_vargs+0x62/0x80
[    6.696914]  kobject_add+0x35/0x80
[    6.697642]  blk_mq_register_hctx+0x95/0xc0
[    6.698447]  blk_mq_register_dev+0xc9/0x110
[    6.699255]  blk_register_queue+0x7b/0x130
[    6.700059]  device_add_disk+0x1c6/0x460
[    6.700849]  sd_probe_async+0xf1/0x1c0
[    6.701628]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.702484]  async_run_entry_fn+0x30/0x190
[    6.703284]  ? process_one_work+0x12f/0x430
[    6.704098]  process_one_work+0x1aa/0x430
[    6.704894]  ? process_one_work+0x12f/0x430
[    6.705704]  worker_thread+0x1dd/0x470
[    6.706488]  kthread+0xd4/0x100
[    6.707198]  ? process_one_work+0x430/0x430
[    6.708016]  ? __kthread_create_on_node+0x180/0x180
[    6.708909]  ret_from_fork+0x21/0x2c
[    6.709676] ---[ end trace 1a7726d7c3d3c8d0 ]---
[    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
[    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.026965] sd 0:0:0:0: [sda] Write Protect is off
[    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.546964] sd 0:0:0:0: [sda] Write Protect is off
[    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
[    6.648723] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.649811] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.651418] Workqueue: events_unbound async_run_entry_fn
[    6.652347] Call Trace:
[    6.652987]  dump_stack+0x79/0xa4
[    6.653716]  kobject_init+0x75/0x90
[    6.654452]  blk_mq_register_dev+0x2a/0x110
[    6.655269]  blk_register_queue+0x7b/0x130
[    6.656080]  device_add_disk+0x1c6/0x460
[    6.656866]  sd_probe_async+0xf1/0x1c0
[    6.657634]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.658501]  async_run_entry_fn+0x30/0x190
[    6.659311]  ? process_one_work+0x12f/0x430
[    6.660113]  process_one_work+0x1aa/0x430
[    6.660901]  ? process_one_work+0x12f/0x430
[    6.661716]  worker_thread+0x1dd/0x470
[    6.662479]  kthread+0xd4/0x100
[    6.663175]  ? process_one_work+0x430/0x430
[    6.663984]  ? __kthread_create_on_node+0x180/0x180
[    6.664869]  ret_from_fork+0x21/0x2c
[    6.665638] kobject (ffab51ec): tried to init an initialized object, something is seriously wrong.
[    6.667290] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.668372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.669984] Workqueue: events_unbound async_run_entry_fn
[    6.670909] Call Trace:
[    6.671540]  dump_stack+0x79/0xa4
[    6.672266]  kobject_init+0x75/0x90
[    6.673011]  blk_mq_register_dev+0x4c/0x110
[    6.673832]  blk_register_queue+0x7b/0x130
[    6.674633]  device_add_disk+0x1c6/0x460
[    6.675413]  sd_probe_async+0xf1/0x1c0
[    6.676191]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.677057]  async_run_entry_fn+0x30/0x190
[    6.677860]  ? process_one_work+0x12f/0x430
[    6.678667]  process_one_work+0x1aa/0x430
[    6.679455]  ? process_one_work+0x12f/0x430
[    6.680269]  worker_thread+0x1dd/0x470
[    6.681036]  kthread+0xd4/0x100
[    6.681737]  ? process_one_work+0x430/0x430
[    6.682540]  ? __kthread_create_on_node+0x180/0x180
[    6.683420]  ret_from_fork+0x21/0x2c
[    6.684207] ------------[ cut here ]------------
[    6.685067] WARNING: CPU: 0 PID: 99 at ./include/linux/kref.h:46 kobject_get+0x7f/0x90
[    6.686592] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.687680] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.689280] Workqueue: events_unbound async_run_entry_fn
[    6.690208] Call Trace:
[    6.690843]  dump_stack+0x79/0xa4
[    6.691563]  __warn+0xd2/0xf0
[    6.692246]  ? kobject_get+0x7f/0x90
[    6.692992]  warn_slowpath_null+0x25/0x30
[    6.693787]  kobject_get+0x7f/0x90
[    6.694505]  kobject_add_internal+0x2e/0x360
[    6.695322]  ? kfree_const+0x18/0x20
[    6.696071]  ? kobject_set_name_vargs+0x62/0x80
[    6.696914]  kobject_add+0x35/0x80
[    6.697642]  blk_mq_register_hctx+0x95/0xc0
[    6.698447]  blk_mq_register_dev+0xc9/0x110
[    6.699255]  blk_register_queue+0x7b/0x130
[    6.700059]  device_add_disk+0x1c6/0x460
[    6.700849]  sd_probe_async+0xf1/0x1c0
[    6.701628]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.702484]  async_run_entry_fn+0x30/0x190
[    6.703284]  ? process_one_work+0x12f/0x430
[    6.704098]  process_one_work+0x1aa/0x430
[    6.704894]  ? process_one_work+0x12f/0x430
[    6.705704]  worker_thread+0x1dd/0x470
[    6.706488]  kthread+0xd4/0x100
[    6.707198]  ? process_one_work+0x430/0x430
[    6.708016]  ? __kthread_create_on_node+0x180/0x180
[    6.708909]  ret_from_fork+0x21/0x2c
[    6.709676] ---[ end trace 1a7726d7c3d3c8d0 ]---
csi host0: scsi_debug: version 1.86 [20160430]
[    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.026965] sd 0:0:0:0: [sda] Write Protect is off
[    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.546964] sd 0:0:0:0: [sda] Write Protect is off
[    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
[    6.648723] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.649811] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.651418] Workqueue: events_unbound async_run_entry_fn
[    6.652347] Call Trace:
[    6.652987]  dump_stack+0x79/0xa4
[    6.653716]  kobject_init+0x75/0x90
[    6.654452]  blk_mq_register_dev+0x2a/0x110
[    6.655269]  blk_register_queue+0x7b/0x130
[    6.656080]  device_add_disk+0x1c6/0x460
[    6.656866]  sd_probe_async+0xf1/0x1c0
[    6.657634]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.658501]  async_run_entry_fn+0x30/0x190
[    6.659311]  ? process_one_work+0x12f/0x430
[    6.660113]  process_one_work+0x1aa/0x430
[    6.660901]  ? process_one_work+0x12f/0x430
[    6.661716]  worker_thread+0x1dd/0x470
[    6.662479]  kthread+0xd4/0x100
[    6.663175]  ? process_one_work+0x430/0x430
[    6.663984]  ? __kthread_create_on_node+0x180/0x180
[    6.664869]  ret_from_fork+0x21/0x2c
[    6.665638] kobject (ffab51ec): tried to init an initialized object, something is seriously wrong.
[    6.667290] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.668372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.669984] Workqueue: events_unbound async_run_entry_fn
[    6.670909] Call Trace:
[    6.671540]  dump_stack+0x79/0xa4
[    6.672266]  kobject_init+0x75/0x90
[    6.673011]  blk_mq_register_dev+0x4c/0x110
[    6.673832]  blk_register_queue+0x7b/0x130
[    6.674633]  device_add_disk+0x1c6/0x460
[    6.675413]  sd_probe_async+0xf1/0x1c0
[    6.676191]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.677057]  async_run_entry_fn+0x30/0x190
[    6.677860]  ? process_one_work+0x12f/0x430
[    6.678667]  process_one_work+0x1aa/0x430
[    6.679455]  ? process_one_work+0x12f/0x430
[    6.680269]  worker_thread+0x1dd/0x470
[    6.681036]  kthread+0xd4/0x100
[    6.681737]  ? process_one_work+0x430/0x430
[    6.682540]  ? __kthread_create_on_node+0x180/0x180
[    6.683420]  ret_from_fork+0x21/0x2c
[    6.684207] ------------[ cut here ]------------
[    6.685067] WARNING: CPU: 0 PID: 99 at ./include/linux/kref.h:46 kobject_get+0x7f/0x90
[    6.686592] CPU: 0 PID: 99 Comm: kworker/u2:1 Not tainted 4.10.0-rc7 #932
[    6.687680] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.689280] Workqueue: events_unbound async_run_entry_fn
[    6.690208] Call Trace:
[    6.690843]  dump_stack+0x79/0xa4
[    6.691563]  __warn+0xd2/0xf0
[    6.692246]  ? kobject_get+0x7f/0x90
[    6.692992]  warn_slowpath_null+0x25/0x30
[    6.693787]  kobject_get+0x7f/0x90
[    6.694505]  kobject_add_internal+0x2e/0x360
[    6.695322]  ? kfree_const+0x18/0x20
[    6.696071]  ? kobject_set_name_vargs+0x62/0x80
[    6.696914]  kobject_add+0x35/0x80
[    6.697642]  blk_mq_register_hctx+0x95/0xc0
[    6.698447]  blk_mq_register_dev+0xc9/0x110
[    6.699255]  blk_register_queue+0x7b/0x130
[    6.700059]  device_add_disk+0x1c6/0x460
[    6.700849]  sd_probe_async+0xf1/0x1c0
[    6.701628]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.702484]  async_run_entry_fn+0x30/0x190
[    6.703284]  ? process_one_work+0x12f/0x430
[    6.704098]  process_one_work+0x1aa/0x430
[    6.704894]  ? process_one_work+0x12f/0x430
[    6.705704]  worker_thread+0x1dd/0x470
[    6.706488]  kthread+0xd4/0x100
[    6.707198]  ? process_one_work+0x430/0x430
[    6.708016]  ? __kthread_create_on_node+0x180/0x180
[    6.708909]  ret_from_fork+0x21/0x2c
[    6.709676] ---[ end trace 1a7726d7c3d3c8d0 ]---

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
  2017-02-07  0:14         ` [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup James Bottomley
@ 2017-02-07  4:09           ` Jens Axboe
  2017-02-07  5:42             ` Dan Williams
  2017-02-11 16:07             ` James Bottomley
  0 siblings, 2 replies; 6+ messages in thread
From: Jens Axboe @ 2017-02-07  4:09 UTC (permalink / raw)
  To: James Bottomley, Dan Williams, Christoph Hellwig
  Cc: kernel test robot, Bart Van Assche, Martin K. Petersen, Jan Kara,
	Omar Sandoval, Omar Sandoval, LKML, Jens Axboe, LKP, linux-scsi,
	linux-block

On 02/06/2017 05:14 PM, James Bottomley wrote:
> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
>>> Dan,
>>>
>>> can you please quote your emails?  I can't find any content 
>>> inbetween all these quotes.
>>
>> Sorry, I'm using gmail, but I'll switch to attaching the logs.
>>
>> So with help from Xiaolong I was able to reproduce this, and it does
>> not appear to be a regression. We simply change the failure output of
>> an existing bug. Attached is a log of the same test on v4.10-rc7 
>> (i.e. without the recent block/scsi fixes), and it shows sda being
>> registered twice.
>>
>> "[    6.647077] kobject (d5078ca4): tried to init an initialized
>> object, something is seriously wrong."
>>
>> The change that "scsi, block: fix duplicate bdi name registration
>> crashes" makes is to properly try to register sdb since the sda devt
>> is still alive. However that's not a fix because we've managed to 
>> call blk_register_queue() twice on the same queue.
> 
> OK, time to involve others: linux-scsi and linux-block cc'd and I've
> inserted the log below.
> 
> James
> 
> ---
> 
> [    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
> [    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
> [    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
> [    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [    6.026965] sd 0:0:0:0: [sda] Write Protect is off
> [    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
> [    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> [    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
> [    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [    6.546964] sd 0:0:0:0: [sda] Write Protect is off
> [    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.

So sda is probed twice, and hilarity ensues when we try to register it
twice.  I can't reproduce this, using scsi_debug and with scsi_async
enabled.

This is running linux-next? What's your .config?

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
  2017-02-07  4:09           ` Jens Axboe
@ 2017-02-07  5:42             ` Dan Williams
  2017-02-09  0:08               ` James Bottomley
  2017-02-11 16:07             ` James Bottomley
  1 sibling, 1 reply; 6+ messages in thread
From: Dan Williams @ 2017-02-07  5:42 UTC (permalink / raw)
  To: Jens Axboe
  Cc: James Bottomley, Christoph Hellwig, kernel test robot,
	Bart Van Assche, Martin K. Petersen, Jan Kara, Omar Sandoval,
	Omar Sandoval, LKML, Jens Axboe, LKP, linux-scsi, linux-block

On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe <axboe@fb.com> wrote:
> On 02/06/2017 05:14 PM, James Bottomley wrote:
>> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
>>>> Dan,
>>>>
>>>> can you please quote your emails?  I can't find any content
>>>> inbetween all these quotes.
>>>
>>> Sorry, I'm using gmail, but I'll switch to attaching the logs.
>>>
>>> So with help from Xiaolong I was able to reproduce this, and it does
>>> not appear to be a regression. We simply change the failure output of
>>> an existing bug. Attached is a log of the same test on v4.10-rc7
>>> (i.e. without the recent block/scsi fixes), and it shows sda being
>>> registered twice.
>>>
>>> "[    6.647077] kobject (d5078ca4): tried to init an initialized
>>> object, something is seriously wrong."
>>>
>>> The change that "scsi, block: fix duplicate bdi name registration
>>> crashes" makes is to properly try to register sdb since the sda devt
>>> is still alive. However that's not a fix because we've managed to
>>> call blk_register_queue() twice on the same queue.
>>
>> OK, time to involve others: linux-scsi and linux-block cc'd and I've
>> inserted the log below.
>>
>> James
>>
>> ---
>>
>> [    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
>> [    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
>> [    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
>> [    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
>> [    6.026965] sd 0:0:0:0: [sda] Write Protect is off
>> [    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
>> [    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
>> [    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
>> [    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
>> [    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
>> [    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
>> [    6.546964] sd 0:0:0:0: [sda] Write Protect is off
>> [    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
>> [    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
>> [    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
>
> So sda is probed twice, and hilarity ensues when we try to register it
> twice.  I can't reproduce this, using scsi_debug and with scsi_async
> enabled.
>
> This is running linux-next? What's your .config?
>

The original failure report is here:

http://marc.info/?l=linux-kernel&m=148619222300774&w=2

...but it reproduces on current mainline with the same config. I
haven't spotted what makes scsi_debug behave like this.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
  2017-02-07  5:42             ` Dan Williams
@ 2017-02-09  0:08               ` James Bottomley
  2017-02-10  3:11                 ` Dan Williams
  0 siblings, 1 reply; 6+ messages in thread
From: James Bottomley @ 2017-02-09  0:08 UTC (permalink / raw)
  To: Dan Williams, Jens Axboe
  Cc: Christoph Hellwig, kernel test robot, Bart Van Assche,
	Martin K. Petersen, Jan Kara, Omar Sandoval, Omar Sandoval, LKML,
	Jens Axboe, LKP, linux-scsi, linux-block

On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote:
> On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe <axboe@fb.com> wrote:
> > On 02/06/2017 05:14 PM, James Bottomley wrote:
> > > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
> > > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de>
> > > > wrote:
> > > > > Dan,
> > > > > 
> > > > > can you please quote your emails?  I can't find any content
> > > > > inbetween all these quotes.
> > > > 
> > > > Sorry, I'm using gmail, but I'll switch to attaching the logs.
> > > > 
> > > > So with help from Xiaolong I was able to reproduce this, and it
> > > > does
> > > > not appear to be a regression. We simply change the failure
> > > > output of
> > > > an existing bug. Attached is a log of the same test on v4.10
> > > > -rc7
> > > > (i.e. without the recent block/scsi fixes), and it shows sda
> > > > being
> > > > registered twice.
> > > > 
> > > > "[    6.647077] kobject (d5078ca4): tried to init an
> > > > initialized
> > > > object, something is seriously wrong."
> > > > 
> > > > The change that "scsi, block: fix duplicate bdi name
> > > > registration
> > > > crashes" makes is to properly try to register sdb since the sda
> > > > devt
> > > > is still alive. However that's not a fix because we've managed
> > > > to
> > > > call blk_register_queue() twice on the same queue.
> > > 
> > > OK, time to involve others: linux-scsi and linux-block cc'd and
> > > I've
> > > inserted the log below.
> > > 
> > > James
> > > 
> > > ---
> > > 
> > > [    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
> > > [    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1,
> > > statistics=0
> > > [    5.971895] scsi 0:0:0:0: Direct-Access     Linux   
> > >  scsi_debug       0186 PQ: 0 ANSI: 7
> > > [    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks:
> > > (8.39 MB/8.00 MiB)
> > > [    6.026965] sd 0:0:0:0: [sda] Write Protect is off
> > > [    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> > > [    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read
> > > cache: enabled, supports DPO and FUA
> > > [    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
> > > [    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> > > [    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
> > > [    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks:
> > > (8.39 MB/8.00 MiB)
> > > [    6.546964] sd 0:0:0:0: [sda] Write Protect is off
> > > [    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> > > [    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read
> > > cache: enabled, supports DPO and FUA
> > > [    6.647077] kobject (d5078ca4): tried to init an initialized
> > > object, something is seriously wrong.
> > 
> > So sda is probed twice, and hilarity ensues when we try to register
> > it
> > twice.  I can't reproduce this, using scsi_debug and with
> > scsi_async
> > enabled.
> > 
> > This is running linux-next? What's your .config?
> > 
> 
> The original failure report is here:
> 
> http://marc.info/?l=linux-kernel&m=148619222300774&w=2
> 
> ...but it reproduces on current mainline with the same config. I
> haven't spotted what makes scsi_debug behave like this.

Looking at the config, it's a static debug with report luns enabled. 
 Is it as simple as the fact that we probe lun 0 manually to see if the
target exists, but then we don't account for the fact that we already
did this, so if it turns up again in the report lun scan, we'll probe
it again leading to a double add.  If that theory is correct, this may
be the fix (compile tested only).

James

---

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 6f7128f..ba4be08 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1441,6 +1441,10 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
 	for (lunp = &lun_data[1]; lunp <= &lun_data[num_luns]; lunp++) {
 		lun = scsilun_to_int(lunp);
 
+		if (lun == 0)
+			/* already scanned LUN 0 */
+			continue;
+
 		if (lun > sdev->host->max_lun) {
 			sdev_printk(KERN_WARNING, sdev,
 				    "lun%llu has a LUN larger than"

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
  2017-02-09  0:08               ` James Bottomley
@ 2017-02-10  3:11                 ` Dan Williams
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2017-02-10  3:11 UTC (permalink / raw)
  To: James Bottomley
  Cc: Jens Axboe, Christoph Hellwig, kernel test robot, Bart Van Assche,
	Martin K. Petersen, Jan Kara, Omar Sandoval, Omar Sandoval, LKML,
	Jens Axboe, LKP, linux-scsi, linux-block

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

On Wed, Feb 8, 2017 at 4:08 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote:
[..]
>> ...but it reproduces on current mainline with the same config. I
>> haven't spotted what makes scsi_debug behave like this.
>
> Looking at the config, it's a static debug with report luns enabled.
>  Is it as simple as the fact that we probe lun 0 manually to see if the
> target exists, but then we don't account for the fact that we already
> did this, so if it turns up again in the report lun scan, we'll probe
> it again leading to a double add.  If that theory is correct, this may
> be the fix (compile tested only).
>
> James
>
> ---
>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 6f7128f..ba4be08 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1441,6 +1441,10 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
>         for (lunp = &lun_data[1]; lunp <= &lun_data[num_luns]; lunp++) {
>                 lun = scsilun_to_int(lunp);
>
> +               if (lun == 0)
> +                       /* already scanned LUN 0 */
> +                       continue;
> +
>                 if (lun > sdev->host->max_lun) {
>                         sdev_printk(KERN_WARNING, sdev,
>                                     "lun%llu has a LUN larger than"

I gave this a shot on top of linux-next, but still hit the failure.
Log attached.

[-- Attachment #2: log --]
[-- Type: application/octet-stream, Size: 8819 bytes --]

[    5.980959] st: Version 20160209, fixed bufsize 32768, s/g segs 256
[    5.991170] osst :I: Tape driver with OnStream support version 0.99.4
[    5.991170] osst :I: $Id: osst.c,v 1.73 2005/01/01 21:13:34 wriede Exp $
[    5.993376] SCSI Media Changer driver v0.25 
[    5.995157] scsi host0: scsi_debug: version 1.86 [20160430]
[    5.995157]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    5.997479] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.030073] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.050047] sd 0:0:0:0: [sda] Write Protect is off
[    6.051006] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
[    6.090067] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.510044] sd 0:0:0:0: [sda] Attached SCSI disk
[    6.511614] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[    6.512740] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    6.550065] sd 0:0:0:0: [sdb] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
[    6.570050] sd 0:0:0:0: [sdb] Write Protect is off
[    6.570996] sd 0:0:0:0: [sdb] Mode Sense: 73 00 10 08
[    6.610113] sd 0:0:0:0: [sdb] Write cache: enabled, read cache: enabled, supports DPO and FUA
[    6.670309] kobject (d5cb36a4): tried to init an initialized object, something is seriously wrong.
[    6.673969] CPU: 0 PID: 100 Comm: kworker/u2:1 Not tainted 4.10.0-rc7-next-20170207-00005-g43256e7301aa #950
[    6.678132] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.680063] Workqueue: events_unbound async_run_entry_fn
[    6.680063] Call Trace:
[    6.680063]  dump_stack+0x79/0xa4
[    6.680063]  kobject_init+0x75/0x90
[    6.680063]  ? blk_mq_disable_hotplug+0xf/0x20
[    6.680063]  blk_mq_register_dev+0x2a/0x120
[    6.680063]  blk_register_queue+0x7f/0x160
[    6.680063]  device_add_disk+0x1e3/0x480
[    6.680063]  sd_probe_async+0xf1/0x1c0
[    6.680063]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.680063]  async_run_entry_fn+0x30/0x190
[    6.680063]  ? process_one_work+0x12f/0x430
[    6.680063]  process_one_work+0x1aa/0x430
[    6.680063]  ? process_one_work+0x12f/0x430
[    6.680063]  worker_thread+0x1dd/0x470
[    6.680063]  kthread+0xd4/0x100
[    6.680063]  ? process_one_work+0x430/0x430
[    6.680063]  ? __kthread_create_on_node+0x180/0x180
[    6.680063]  ret_from_fork+0x21/0x2c
[    6.706694] kobject (ffab2dec): tried to init an initialized object, something is seriously wrong.
[    6.709061] CPU: 0 PID: 100 Comm: kworker/u2:1 Not tainted 4.10.0-rc7-next-20170207-00005-g43256e7301aa #950
[    6.711577] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.713896] Workqueue: events_unbound async_run_entry_fn
[    6.715240] Call Trace:
[    6.716160]  dump_stack+0x79/0xa4
[    6.716677]  kobject_init+0x75/0x90
[    6.716677]  blk_mq_register_dev+0x4c/0x120
[    6.716677]  blk_register_queue+0x7f/0x160
[    6.716677]  device_add_disk+0x1e3/0x480
[    6.716677]  sd_probe_async+0xf1/0x1c0
[    6.716677]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.716677]  async_run_entry_fn+0x30/0x190
[    6.716677]  ? process_one_work+0x12f/0x430
[    6.716677]  process_one_work+0x1aa/0x430
[    6.716677]  ? process_one_work+0x12f/0x430
[    6.716677]  worker_thread+0x1dd/0x470
[    6.716677]  kthread+0xd4/0x100
[    6.716677]  ? process_one_work+0x430/0x430
[    6.716677]  ? __kthread_create_on_node+0x180/0x180
[    6.716677]  ret_from_fork+0x21/0x2c
[    6.734034] ------------[ cut here ]------------
[    6.735233] WARNING: CPU: 0 PID: 100 at ./include/linux/kref.h:54 kobject_get+0x7f/0x90
[    6.737285] CPU: 0 PID: 100 Comm: kworker/u2:1 Not tainted 4.10.0-rc7-next-20170207-00005-g43256e7301aa #950
[    6.739579] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.741722] Workqueue: events_unbound async_run_entry_fn
[    6.742966] Call Trace:
[    6.743809]  dump_stack+0x79/0xa4
[    6.743899]  __warn+0xd2/0xf0
[    6.743899]  ? kobject_get+0x7f/0x90
[    6.743899]  warn_slowpath_null+0x25/0x30
[    6.743899]  kobject_get+0x7f/0x90
[    6.743899]  kobject_add_internal+0x2e/0x360
[    6.743899]  ? kfree_const+0x18/0x20
[    6.743899]  ? kobject_set_name_vargs+0x62/0x80
[    6.743899]  kobject_add+0x35/0x80
[    6.743899]  ? up_write+0x16/0x40
[    6.743899]  blk_mq_register_hctx+0x95/0xc0
[    6.743899]  blk_mq_register_dev+0xd9/0x120
[    6.743899]  blk_register_queue+0x7f/0x160
[    6.743899]  device_add_disk+0x1e3/0x480
[    6.743899]  sd_probe_async+0xf1/0x1c0
[    6.743899]  ? __lock_acquire.isra.14+0x43b/0x940
[    6.743899]  async_run_entry_fn+0x30/0x190
[    6.743899]  ? process_one_work+0x12f/0x430
[    6.743899]  process_one_work+0x1aa/0x430
[    6.743899]  ? process_one_work+0x12f/0x430
[    6.743899]  worker_thread+0x1dd/0x470
[    6.743899]  kthread+0xd4/0x100
[    6.743899]  ? process_one_work+0x430/0x430
[    6.743899]  ? __kthread_create_on_node+0x180/0x180
[    6.743899]  ret_from_fork+0x21/0x2c
[    6.768405] ---[ end trace 7b77f5d77668026b ]---
[    6.920058] sd 0:0:0:0: [sdb] Attached SCSI disk
[    6.921534] sd 0:0:0:0: [sdb] Synchronizing SCSI cache
[    6.950611] scsi host0: scsi_debug: version 1.86 [20160430]
[    6.950611]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    6.953078] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
[    6.955028] ------------[ cut here ]------------
[    6.956026] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x58/0x70
[    6.957731] sysfs: cannot create duplicate filename '/class/scsi_disk/0:0:0:0'
[    6.959408] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G        W       4.10.0-rc7-next-20170207-00005-g43256e7301aa #950
[    6.960027] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.1-1.fc24 04/01/2014
[    6.960027] Call Trace:
[    6.960027]  dump_stack+0x79/0xa4
[    6.960027]  __warn+0xd2/0xf0
[    6.960027]  ? sysfs_warn_dup+0x58/0x70
[    6.960027]  warn_slowpath_fmt+0x36/0x40
[    6.960027]  sysfs_warn_dup+0x58/0x70
[    6.960027]  sysfs_do_create_link_sd.isra.0+0x9e/0xb0
[    6.960027]  sysfs_create_link+0x20/0x40
[    6.960027]  device_add+0x218/0x610
[    6.960027]  ? kvasprintf_const+0x49/0x60
[    6.960027]  ? kobject_set_name_vargs+0x62/0x80
[    6.960027]  sd_probe+0x31a/0x390
[    6.960027]  ? _raw_spin_unlock+0x1d/0x30
[    6.960027]  driver_probe_device+0x190/0x4a0
[    6.960027]  __device_attach_driver+0x6f/0x100
[    6.960027]  ? klist_next+0x6e/0x100
[    6.960027]  ? __driver_attach+0xf0/0xf0
[    6.960027]  bus_for_each_drv+0x47/0x80
[    6.960027]  __device_attach+0xa8/0x120
[    6.960027]  ? __driver_attach+0xf0/0xf0
[    6.960027]  device_initial_probe+0xd/0x10
[    6.960027]  bus_probe_device+0x77/0x80
[    6.960027]  device_add+0x320/0x610
[    6.960027]  scsi_sysfs_add_sdev+0x85/0x2b0
[    6.960027]  ? scsi_attach_vpd+0x1f9/0x210
[    6.960027]  scsi_probe_and_add_lun+0xd44/0xe70
[    6.960027]  __scsi_scan_target+0xd8/0x690
[    6.960027]  ? __pm_runtime_resume+0x37/0x90
[    6.960027]  scsi_scan_channel+0x8f/0xb0
[    6.960027]  scsi_scan_host_selected+0x100/0x180
[    6.960027]  do_scsi_scan_host+0x8a/0x90
[    6.960027]  scsi_scan_host+0x15a/0x1a0
[    6.960027]  sdebug_driver_probe+0x14f/0x3d0
[    6.960027]  ? _raw_spin_unlock+0x1d/0x30
[    6.960027]  ? devices_kset_move_last+0x71/0xc0
[    6.960027]  ? sysfs_create_link+0x20/0x40
[    6.960027]  driver_probe_device+0xd4/0x4a0
[    6.960027]  __device_attach_driver+0x6f/0x100
[    6.960027]  ? klist_next+0x6e/0x100
[    6.960027]  ? __driver_attach+0xf0/0xf0
[    6.960027]  bus_for_each_drv+0x47/0x80
[    6.960027]  __device_attach+0xa8/0x120
[    6.960027]  ? __driver_attach+0xf0/0xf0
[    6.960027]  device_initial_probe+0xd/0x10
[    6.960027]  bus_probe_device+0x77/0x80
[    6.960027]  device_add+0x320/0x610
[    6.960027]  ? pm_runtime_init+0xea/0xf0
[    6.960027]  device_register+0x12/0x20
[    6.960027]  sdebug_add_adapter+0xda/0x1e0
[    6.960027]  ? driver_register+0x83/0xe0
[    6.960027]  scsi_debug_init+0x5a0/0x6eb
[    6.960027]  ? kobject_uevent+0xa/0x10
[    6.960027]  ? driver_register+0x83/0xe0
[    6.960027]  ? scsi_register_driver+0xf/0x20
[    6.960027]  ? init_ch_module+0x9d/0x9d
[    6.960027]  do_one_initcall+0x7b/0x132
[    6.960027]  ? kernel_init_freeable+0xe7/0x183
[    6.960027]  kernel_init_freeable+0x10a/0x183
[    6.960027]  ? rest_init+0xb0/0xb0
[    6.960027]  kernel_init+0xb/0x100
[    6.960027]  ? schedule_tail+0xc/0x70
[    6.960027]  ? rest_init+0xb0/0xb0
[    6.960027]  ret_from_fork+0x21/0x2c
[    7.030980] ---[ end trace 7b77f5d77668026c ]---
[    7.032025] sd: probe of 0:0:0:0 failed with error -17
[    7.033172] scsi 0:0:0:0: Attached scsi generic sg0 type 0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
  2017-02-07  4:09           ` Jens Axboe
  2017-02-07  5:42             ` Dan Williams
@ 2017-02-11 16:07             ` James Bottomley
  1 sibling, 0 replies; 6+ messages in thread
From: James Bottomley @ 2017-02-11 16:07 UTC (permalink / raw)
  To: Jens Axboe, Dan Williams, Christoph Hellwig
  Cc: kernel test robot, Bart Van Assche, Martin K. Petersen, Jan Kara,
	Omar Sandoval, Omar Sandoval, LKML, Jens Axboe, LKP, linux-scsi,
	linux-block

On Mon, 2017-02-06 at 21:09 -0700, Jens Axboe wrote:
> On 02/06/2017 05:14 PM, James Bottomley wrote:
> > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
> > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de>
> > > wrote:
> > > > Dan,
> > > > 
> > > > can you please quote your emails?  I can't find any content 
> > > > inbetween all these quotes.
> > > 
> > > Sorry, I'm using gmail, but I'll switch to attaching the logs.
> > > 
> > > So with help from Xiaolong I was able to reproduce this, and it
> > > does
> > > not appear to be a regression. We simply change the failure
> > > output of
> > > an existing bug. Attached is a log of the same test on v4.10-rc7 
> > > (i.e. without the recent block/scsi fixes), and it shows sda
> > > being
> > > registered twice.
> > > 
> > > "[    6.647077] kobject (d5078ca4): tried to init an initialized
> > > object, something is seriously wrong."
> > > 
> > > The change that "scsi, block: fix duplicate bdi name registration
> > > crashes" makes is to properly try to register sdb since the sda
> > > devt
> > > is still alive. However that's not a fix because we've managed to
> > > call blk_register_queue() twice on the same queue.
> > 
> > OK, time to involve others: linux-scsi and linux-block cc'd and
> > I've
> > inserted the log below.
> > 
> > James
> > 
> > ---
> > 
> > [    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
> > [    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1,
> > statistics=0
> > [    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug 
> >       0186 PQ: 0 ANSI: 7
> > [    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks:
> > (8.39 MB/8.00 MiB)
> > [    6.026965] sd 0:0:0:0: [sda] Write Protect is off
> > [    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> > [    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
> > enabled, supports DPO and FUA
> > [    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
> > [    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> > [    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
> > [    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks:
> > (8.39 MB/8.00 MiB)
> > [    6.546964] sd 0:0:0:0: [sda] Write Protect is off
> > [    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> > [    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
> > enabled, supports DPO and FUA
> > [    6.647077] kobject (d5078ca4): tried to init an initialized
> > object, something is seriously wrong.
> 
> So sda is probed twice, and hilarity ensues when we try to register 
> it twice.  I can't reproduce this, using scsi_debug and with 
> scsi_async enabled.

Actually, when you look closely, it's not a double add; it's an
add/remove/add.  You can see this from

[    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache

That's from sd_shutdown() as the driver is removing.  It looks like
something with the config caused the built in SCSI debug to do this
(not sure why), but since the stack trace is in block, I think the bug
is in the remove path: something didn't release the mq object
correctly.

James

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-02-11 16:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170204070936.GE12121@yexl-desktop>
     [not found] ` <CAPcyv4j0syAsinM-KbeefKysJhM9zt6kvrX=0c2HrtPV_tRAHQ@mail.gmail.com>
     [not found]   ` <CAPcyv4gBQDuj65KRmFvP2q4Qt3d3xycM8L_TypAzYkvhmUSh6A@mail.gmail.com>
     [not found]     ` <20170205091314.GA3042@lst.de>
     [not found]       ` <CAPcyv4gE0+3pZQV=V75wxddFVhWeAz1abfJ=q8D1Zi+8Oi17rA@mail.gmail.com>
2017-02-07  0:14         ` [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup James Bottomley
2017-02-07  4:09           ` Jens Axboe
2017-02-07  5:42             ` Dan Williams
2017-02-09  0:08               ` James Bottomley
2017-02-10  3:11                 ` Dan Williams
2017-02-11 16:07             ` James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox