[PATCHv2] hpsa: expose enclosures

[PATCHv2] hpsa: expose enclosures

[Hannes Reinecke]

Some servers have a built-in enclosure which will show up on the
same bus as the internal physical devices. This patch fixes the
driver to expose them.

Cc: Don Brace <don.brace@microsemi.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/hpsa.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 524a0c7..a77ed5a 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -4407,7 +4407,10 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h)
 		 * Expose all devices except for physical devices that
 		 * are masked.
 		 */
-		if (MASKED_DEVICE(lunaddrbytes) && this_device->physical_device)
+		if (this_device->devtype == TYPE_ENCLOSURE)
+			this_device->expose_device = 1;
+		else if (MASKED_DEVICE(lunaddrbytes) &&
+			 this_device->physical_device)
 			this_device->expose_device = 0;
 		else
 			this_device->expose_device = 1;
-- 
1.8.5.6

RE: [PATCHv2] hpsa: expose enclosures

[Don Brace]

> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
> Sent: Thursday, February 23, 2017 4:55 AM
> To: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Christoph Hellwig <hch@lst.de>; James Bottomley
> <james.bottomley@hansenpartnership.com>; linux-scsi@vger.kernel.org;
> Hannes Reinecke <hare@suse.de>; Don Brace
> <don.brace@microsemi.com>; Hannes Reinecke <hare@suse.com>
> Subject: [PATCHv2] hpsa: expose enclosures
> 
> EXTERNAL EMAIL
> 
> 
> Some servers have a built-in enclosure which will show up on the
> same bus as the internal physical devices. This patch fixes the
> driver to expose them.
> 
> Cc: Don Brace <don.brace@microsemi.com>
> Signed-off-by: Hannes Reinecke <hare@suse.com>

Masking various SES targets is a conscious choice, not a design oversight.
So, I have to decline this patch.,

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation

> ---
>  drivers/scsi/hpsa.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 524a0c7..a77ed5a 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -4407,7 +4407,10 @@ static void hpsa_update_scsi_devices(struct
> ctlr_info *h)
>                  * Expose all devices except for physical devices that
>                  * are masked.
>                  */
> -               if (MASKED_DEVICE(lunaddrbytes) && this_device-
> >physical_device)
> +               if (this_device->devtype == TYPE_ENCLOSURE)
> +                       this_device->expose_device = 1;
> +               else if (MASKED_DEVICE(lunaddrbytes) &&
> +                        this_device->physical_device)
>                         this_device->expose_device = 0;
>                 else
>                         this_device->expose_device = 1;
> --
> 1.8.5.6

Re: [PATCHv2] hpsa: expose enclosures

[Hannes Reinecke]

On 03/07/2017 04:05 PM, Don Brace wrote:
>> -----Original Message-----
>> From: Hannes Reinecke [mailto:hare@suse.de]
>> Sent: Thursday, February 23, 2017 4:55 AM
>> To: Martin K. Petersen <martin.petersen@oracle.com>
>> Cc: Christoph Hellwig <hch@lst.de>; James Bottomley
>> <james.bottomley@hansenpartnership.com>; linux-scsi@vger.kernel.org;
>> Hannes Reinecke <hare@suse.de>; Don Brace
>> <don.brace@microsemi.com>; Hannes Reinecke <hare@suse.com>
>> Subject: [PATCHv2] hpsa: expose enclosures
>>
>> EXTERNAL EMAIL
>>
>>
>> Some servers have a built-in enclosure which will show up on the
>> same bus as the internal physical devices. This patch fixes the
>> driver to expose them.
>>
>> Cc: Don Brace <don.brace@microsemi.com>
>> Signed-off-by: Hannes Reinecke <hare@suse.com>
> 
> Masking various SES targets is a conscious choice, not a design oversight.
> So, I have to decline this patch.,
> 
Would you be okay with a module parameter for this?
It really feels stupid to present the user with an enclosure device
during boot (as hpsa presents all physical LUNs during booting), but not
exporting it to the user.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.com			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

RE: [PATCHv2] hpsa: expose enclosures

[Don Brace]

> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.com]
> Sent: Tuesday, March 07, 2017 9:25 AM
> To: Don Brace <don.brace@microsemi.com>; Hannes Reinecke
> <hare@suse.de>; Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Christoph Hellwig <hch@lst.de>; James Bottomley
> <james.bottomley@hansenpartnership.com>; linux-scsi@vger.kernel.org
> Subject: Re: [PATCHv2] hpsa: expose enclosures
> 
> EXTERNAL EMAIL
> 
> 
> On 03/07/2017 04:05 PM, Don Brace wrote:
> >> -----Original Message-----
> >> From: Hannes Reinecke [mailto:hare@suse.de]
> >> Sent: Thursday, February 23, 2017 4:55 AM
> >> To: Martin K. Petersen <martin.petersen@oracle.com>
> >> Cc: Christoph Hellwig <hch@lst.de>; James Bottomley
> >> <james.bottomley@hansenpartnership.com>; linux-scsi@vger.kernel.org;
> >> Hannes Reinecke <hare@suse.de>; Don Brace
> >> <don.brace@microsemi.com>; Hannes Reinecke <hare@suse.com>
> >> Subject: [PATCHv2] hpsa: expose enclosures
> >>
> >> EXTERNAL EMAIL
> >>
> >>
> >> Some servers have a built-in enclosure which will show up on the
> >> same bus as the internal physical devices. This patch fixes the
> >> driver to expose them.
> >>
> >> Cc: Don Brace <don.brace@microsemi.com>
> >> Signed-off-by: Hannes Reinecke <hare@suse.com>
> >
> > Masking various SES targets is a conscious choice, not a design oversight.
> > So, I have to decline this patch.,
> >
> Would you be okay with a module parameter for this?
> It really feels stupid to present the user with an enclosure device
> during boot (as hpsa presents all physical LUNs during booting), but not
> exporting it to the user.
> 
> Cheers,
> 
> Hannes

We would not be able to support this as it can cause issues with 
LED management. A customer could pull the wrong drive and lose data because the LED state was incorrect.
That results in support issues.

We like to show the enclosures even if masked as it helps with diagnosing problems.

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation





> --
> Dr. Hannes Reinecke                            zSeries & Storage
> hare@suse.com                                  +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)