public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hare@suse.de" <hare@suse.de>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
	"james.bottomley@hansenpartnership.com"
	<james.bottomley@hansenpartnership.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"jth@kernel.org" <jth@kernel.org>
Subject: Re: [PATCHv2 0/5] SCSI EH cleanup
Date: Mon, 27 Feb 2017 22:10:13 +0000	[thread overview]
Message-ID: <1488233398.2597.3.camel@sandisk.com> (raw)
In-Reply-To: <ef796d74-4425-92ab-d602-c0b66a8cf19d@suse.de>

On Fri, 2017-02-24 at 08:15 +0100, Hannes Reinecke wrote:
> scsi_abort_command() (ie the call which triggers async aborts) is only
> called if the .eh_timed_out() callback returns BLK_EH_NOT_HANDLED.
> So during reconnects we will not schedule any calls to async aborts.
> We _might_ have scheduled an async abort prior to a call to
> srp_reconnect_rport(), but that would be equivalent with calling
> srp_reconnect_rport() with commands still in flight.
> Is that even possible?
> If so, how do you handle these commands after reconnect returns?
> Any I_T_L nexus will be gone from the target, right?

srp_reconnect_rport() can proceed while commands are in flight. What will
happen is that no response will be received for the commands that are in
flight and hence that these commands will time out at the initiator side.
However, any newly submitted commands will be processed normally.

Bart.

      reply	other threads:[~2017-02-27 22:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 16:07 [PATCHv2 0/5] SCSI EH cleanup Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 1/5] libsas: allow async aborts Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 2/5] scsi: make eh_eflags persistent Hannes Reinecke
2017-02-27 22:15   ` Bart Van Assche
2017-02-28 12:09     ` Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 3/5] scsi_error: do not escalate failed EH command Hannes Reinecke
2017-02-27 22:21   ` Bart Van Assche
2017-02-22 16:07 ` [PATCHv2 4/5] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2017-02-27 22:27   ` Bart Van Assche
2017-02-28 12:16     ` Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 5/5] scsi: make asynchronous aborts mandatory Hannes Reinecke
2017-02-27 22:53   ` Bart Van Assche
2017-02-22 19:44 ` [PATCHv2 0/5] SCSI EH cleanup Bart Van Assche
2017-02-23  7:27   ` Hannes Reinecke
2017-02-22 21:21 ` Bart Van Assche
2017-02-23  7:35   ` Hannes Reinecke
2017-02-24  4:01 ` Bart Van Assche
2017-02-24  7:15   ` Hannes Reinecke
2017-02-27 22:10     ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488233398.2597.3.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jth@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox