Re: [PATCH v6] sd: Check for unaligned partial completion

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

On Wed, 2017-03-01 at 17:27 +0900, Damien Le Moal wrote:
> Commit <f2e767bb5d6e> ("mpt3sas: Force request partial completion
> alignment") was not considering the case of commands not operating on
> logical block size units (e.g. REQ_OP_ZONE_REPORT and its 64B aligned
> partial replies). In this case, forcing alignment of resid to the
> device logical block size can break the command result, e.g. in the
> case of REQ_OP_ZONE_REPORT, the exact number of zone reported by the
> device.
> 
> Move the partial completion alignement check of mpt3sas to a generic
> implementation in sd_done(). The check is added within the default
> section of the initial req_op() switch case so that the report and
> reset zone commands are ignored. In addition, as sd_done() is not
> called for passthrough requests, resid corrections are not done as
> intended by the initial mpt3sas patch.
> 
> Fixes: f2e767bb5d6e ("mpt3sas: Force request partial completion alignment")
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>

We want this patch to be included in the v4.10.x stable kernels so I think
that a "Cc: <stable@vger.kernel.org>" tag is needed. Otherwise this patch
looks fine to me. Hence:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>