From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hare@suse.de" <hare@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCHv3 5/6] scsi: make scsi_eh_scmd_add() always succeed
Date: Wed, 1 Mar 2017 23:34:25 +0000 [thread overview]
Message-ID: <1488411244.2699.16.camel@sandisk.com> (raw)
In-Reply-To: <1488359720-130871-6-git-send-email-hare@suse.de>
On Wed, 2017-03-01 at 10:15 +0100, Hannes Reinecke wrote:
> scsi_eh_scmd_add() currently only will fail if no
> error handler thread is started (which will never be the
> case) or if the state machine encounters an illegal transition.
>
> But if we're encountering an invalid state transition
> chances is we cannot fixup things with the error handler.
> So better add a WARN_ON for illegal host states and
> make scsi_dh_scmd_add() a void function.
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2017-03-01 23:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 9:15 [PATCHv3 0/6] SCSI EH cleanup Hannes Reinecke
2017-03-01 9:15 ` [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run Hannes Reinecke
2017-03-01 13:50 ` Steffen Maier
2017-03-01 23:24 ` Bart Van Assche
2017-03-02 8:02 ` Hannes Reinecke
2017-03-02 20:16 ` Benjamin Block
2017-03-13 10:20 ` Hannes Reinecke
2017-03-13 13:37 ` Mauricio Faria de Oliveira
2017-03-13 14:48 ` Hannes Reinecke
2017-03-13 15:54 ` Mauricio Faria de Oliveira
2017-03-01 9:15 ` [PATCHv3 2/6] libsas: allow async aborts Hannes Reinecke
2017-03-01 9:15 ` [PATCHv3 3/6] scsi: make eh_eflags persistent Hannes Reinecke
2017-03-01 23:29 ` Bart Van Assche
2017-03-14 17:51 ` Benjamin Block
2017-03-01 9:15 ` [PATCHv3 4/6] scsi_error: do not escalate failed EH command Hannes Reinecke
2017-03-14 17:56 ` Benjamin Block
2017-03-15 13:54 ` Hannes Reinecke
2017-03-16 11:01 ` Benjamin Block
2017-03-16 11:53 ` Hannes Reinecke
2017-03-21 19:05 ` Benjamin Block
2017-03-23 13:11 ` Hannes Reinecke
2017-03-01 9:15 ` [PATCHv3 5/6] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2017-03-01 23:34 ` Bart Van Assche [this message]
2017-03-14 18:05 ` Benjamin Block
2017-03-01 9:15 ` [PATCHv3 6/6] scsi: make asynchronous aborts mandatory Hannes Reinecke
2017-03-14 17:33 ` Benjamin Block
2017-03-15 13:54 ` Hannes Reinecke
2017-03-15 17:55 ` Benjamin Block
2017-03-16 14:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488411244.2699.16.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).