From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Cc: Anton Blanchard <anton@ozlabs.org>,
james.smart@broadcom.com, dick.kennedy@broadcom.com,
jejb@linux.vnet.ibm.com, jk@ozlabs.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: Add shutdown method for kexec
Date: Tue, 07 Mar 2017 16:24:22 +1100 [thread overview]
Message-ID: <1488864262.2870.149.camel@kernel.crashing.org> (raw)
In-Reply-To: <yq1lgshkau0.fsf@oracle.com>
On Mon, 2017-03-06 at 22:46 -0500, Martin K. Petersen wrote:
> > > > > > "Mauricio" == Mauricio Faria de Oliveira <mauricfo@linux.vn
> > > > > > et.ibm.com> writes:
>
> Mauricio> On 02/12/2017 07:49 PM, Anton Blanchard wrote:
> > > We see lpfc devices regularly fail during kexec. Fix this by
> > > adding a
> > > shutdown method which mirrors the remove method.
>
> Mauricio> @mkp, @jejb: may you please flag this patch for
> stable? Thank
> Mauricio> you.
>
> I don't recall a consensus being reached on this patch.
What would be the opposition ? Without it kexec breaks. With it, it
works ...
Now we all seem to agree that kexec should be overhauled to not use
shutdown but instead unbind drivers, but that's a more long term
project that nobody yet had a chance to tackle.
In the meantime, some systems need a functioning kexec to boot.
Cheers,
Ben.
next prev parent reply other threads:[~2017-03-07 5:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 21:49 [PATCH] scsi: lpfc: Add shutdown method for kexec Anton Blanchard
2017-02-12 23:14 ` Benjamin Herrenschmidt
2017-02-12 23:47 ` Anton Blanchard
2017-02-13 0:21 ` Eric W. Biederman
2017-02-13 1:01 ` Benjamin Herrenschmidt
2017-02-13 21:57 ` Brian King
2017-02-14 2:04 ` Benjamin Herrenschmidt
2017-02-14 14:56 ` Brian King
2017-02-15 2:44 ` Eric W. Biederman
2017-02-14 2:45 ` Eric W. Biederman
2017-02-14 3:39 ` Benjamin Herrenschmidt
2017-03-06 14:52 ` Mauricio Faria de Oliveira
2017-03-07 3:46 ` Martin K. Petersen
2017-03-07 5:24 ` Benjamin Herrenschmidt [this message]
2017-03-07 12:51 ` Mauricio Faria de Oliveira
2017-03-08 1:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488864262.2870.149.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@ozlabs.org \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jk@ozlabs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mauricfo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox