From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] scsi: lpfc: Add shutdown method for kexec Date: Tue, 07 Mar 2017 16:24:22 +1100 Message-ID: <1488864262.2870.149.camel@kernel.crashing.org> References: <20170212214920.28866-1-anton@ozlabs.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:41733 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbdCGFpM (ORCPT ); Tue, 7 Mar 2017 00:45:12 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Martin K. Petersen" , Mauricio Faria de Oliveira Cc: Anton Blanchard , james.smart@broadcom.com, dick.kennedy@broadcom.com, jejb@linux.vnet.ibm.com, jk@ozlabs.org, linux-scsi@vger.kernel.org On Mon, 2017-03-06 at 22:46 -0500, Martin K. Petersen wrote: > > > > > > "Mauricio" == Mauricio Faria de Oliveira > > > > > et.ibm.com> writes: > > Mauricio> On 02/12/2017 07:49 PM, Anton Blanchard wrote: > > > We see lpfc devices regularly fail during kexec. Fix this by > > > adding a > > > shutdown method which mirrors the remove method. > > Mauricio> @mkp, @jejb: may you please flag this patch for > stable?  Thank > Mauricio> you. > > I don't recall a consensus being reached on this patch. What would be the opposition ? Without it kexec breaks. With it, it works ... Now we all seem to agree that kexec should be overhauled to not use shutdown but instead unbind drivers, but that's a more long term project that nobody yet had a chance to tackle. In the meantime, some systems need a functioning kexec to boot. Cheers, Ben.