From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>,
"hare@suse.de" <hare@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hck@suse.de" <hck@suse.de>, "hare@suse.com" <hare@suse.com>
Subject: Re: [PATCH] sd: use async_probe cookie to avoid deadlocks
Date: Tue, 21 Mar 2017 09:33:58 -0400 [thread overview]
Message-ID: <1490103238.2412.17.camel@HansenPartnership.com> (raw)
In-Reply-To: <1490103027.2602.5.camel@sandisk.com>
On Tue, 2017-03-21 at 13:30 +0000, Bart Van Assche wrote:
> On Tue, 2017-03-21 at 09:05 -0400, James Bottomley wrote:
> > How does this preserve ordering? It looks like you have one cookie
> > per sdkp ... is there some sort of ordering guarantee I'm not
> > seeing?
>
> Hello James,
>
> Since the probe order depends on the order in which __async_probe()
> adds entries to the "pending" list, and since the order of the
> __async_probe() calls is not changed by this patch, shouldn't the
> probe order be preserved by this patch?
I don't know: that's what I'm asking. I believe they complete in order
for a single domain. I thought ordering isn't preserved between
domains? So moving to multiple domains loses us ordering of disk
appearance.
James
next prev parent reply other threads:[~2017-03-21 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 12:14 [PATCH] sd: use async_probe cookie to avoid deadlocks Hannes Reinecke
2017-03-21 13:02 ` Bart Van Assche
2017-03-21 13:05 ` James Bottomley
2017-03-21 13:30 ` Bart Van Assche
2017-03-21 13:33 ` James Bottomley [this message]
2017-03-21 13:42 ` Bart Van Assche
2017-03-21 15:32 ` Hannes Reinecke
2017-03-21 15:25 ` Hannes Reinecke
2017-03-21 15:33 ` James Bottomley
2017-03-21 16:21 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490103238.2412.17.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hck@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox