From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "lixiubo@cmss.chinamobile.com" <lixiubo@cmss.chinamobile.com>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "bryantly@linux.vnet.ibm.com" <bryantly@linux.vnet.ibm.com>,
"agrover@redhat.com" <agrover@redhat.com>,
"iliastsi@arrikto.com" <iliastsi@arrikto.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"shli@kernel.org" <shli@kernel.org>,
"sheng@yasker.org" <sheng@yasker.org>,
"namei.unix@gmail.com" <namei.unix@gmail.com>,
"mchristi@redhat.com" <mchristi@redhat.com>
Subject: Re: [PATCHv5 0/2] tcmu: For bugs fix only
Date: Thu, 30 Mar 2017 15:03:40 +0000 [thread overview]
Message-ID: <1490886207.2753.1.camel@sandisk.com> (raw)
In-Reply-To: <1490863702.6977.7.camel@haakon3.risingtidesystems.com>
On Thu, 2017-03-30 at 01:48 -0700, Nicholas A. Bellinger wrote:
> Just for future reference, the flow of these tags should reflect the
> history of the patch. Eg:
>
> Reviewed-by: First reviewer <foo@bar.com>
> Tested-by: First tester <foo2@bar2.com>
> Reviewed-by: Second reviewer <foo3@bar3.com>
> Signed-off-by: Patch Author <you@yourdomain.com>
>
> and then once the subsystem maintainer merges it into his tree, they add
> their own:
>
> Signed-off-by: Subsystem Maintainer <superturboarray@linux-domain.org>
Hi Nic,
I agree that these tags should reflect the history of the patch. I think
that means that the patch author should be mentioned first, Reviewed-by /
Tested-by tags next and the subsystem maintainer sign-off last. At least,
that's how most other maintainers do it.
Bart.
prev parent reply other threads:[~2017-03-30 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 9:07 [PATCHv5 0/2] tcmu: For bugs fix only lixiubo
2017-03-27 9:07 ` [PATCHv5 1/2] tcmu: Fix possible overwrite of t_data_sg's last iov[] lixiubo
2017-03-27 9:07 ` [PATCHv5 2/2] tcmu: Fix wrongly calculating of the base_command_size lixiubo
2017-03-28 18:34 ` Mike Christie
2017-03-30 8:48 ` [PATCHv5 0/2] tcmu: For bugs fix only Nicholas A. Bellinger
2017-03-30 9:11 ` Xiubo Li
2017-03-30 15:03 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490886207.2753.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=agrover@redhat.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=iliastsi@arrikto.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=mchristi@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=namei.unix@gmail.com \
--cc=sheng@yasker.org \
--cc=shli@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).