From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "eguan@redhat.com" <eguan@redhat.com>,
"dmonakhov@openvz.org" <dmonakhov@openvz.org>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/3] Improve block device testing coverage
Date: Fri, 31 Mar 2017 15:11:28 +0000 [thread overview]
Message-ID: <1490973067.2587.1.camel@sandisk.com> (raw)
In-Reply-To: <8737dt228x.fsf@dmlp.sw.ru>
On Fri, 2017-03-31 at 13:02 +0300, Dmitry Monakhov wrote:
> Another good example may be a bug with dirty page cache after blkdiscard
> https://lkml.org/lkml/2017/3/22/789 . This simple bug result in crappy
> fsimage if mkfs relay on discard_zeroes_data behaviour.
> So IMHO basic blkdev test coverage is important filesystem testing. i.e.
> important for xfstests.
Mixing up filesystem tests and block layer / block driver tests in the same
directory is completely wrong. Block driver developers will be primarily
interested in the block tests and may want to skip the filesystem tests.
Filesystem developers will probably run the block tests only once and will
likely run the filesystem tests repeatedly. Mixing up different kinds of
tests in the same directory makes it unnecessarily hard to run block and
filesystem tests separately.
Bart.
next prev parent reply other threads:[~2017-03-31 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 13:19 [PATCH 0/3] Improve block device testing coverage Dmitry Monakhov
2017-03-30 13:19 ` [PATCH 1/3] add lio-target helpers Dmitry Monakhov
2017-03-30 13:19 ` [PATCH 2/3] add test: generic/420 check information lead for lio-fileio Dmitry Monakhov
2017-03-30 13:19 ` [PATCH 3/3] add test: generic/421 basic blockdev T10-DIF-TYPE1 integrity checks Dmitry Monakhov
2017-03-31 6:57 ` [PATCH 0/3] Improve block device testing coverage Christoph Hellwig
2017-03-31 7:43 ` Dmitry Monakhov
2017-03-31 9:38 ` Eryu Guan
2017-03-31 10:02 ` Dmitry Monakhov
2017-03-31 15:11 ` Bart Van Assche [this message]
2017-03-31 16:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490973067.2587.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dmonakhov@openvz.org \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox