Re: [PATCHv4 8/8] scsi: inline command aborts

kbuild test robot
2017-04-05T04:33:52Z

[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]

Hi Hannes,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.11-rc5 next-20170404]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi_error-count-medium-access-timeout-only-once-per-EH-run/20170405-060357
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

>> drivers/scsi/scsi_error.c:120: warning: No description found for parameter 'scmd'
>> drivers/scsi/scsi_error.c:120: warning: Excess function parameter 'work' description in 'scmd_eh_abort_handler'
drivers/scsi/constants.c:1: warning: no structured comments found

vim +/scmd +120 drivers/scsi/scsi_error.c

bb3b621a Ren Mingxin 2013-11-11 104 * if eh_deadline has been set to 'off' during the
76ad3e59 Hannes Reinecke 2013-11-11 105 * time_before call.
76ad3e59 Hannes Reinecke 2013-11-11 106 */
76ad3e59 Hannes Reinecke 2013-11-11 107 if (time_before(jiffies, shost->last_reset + shost->eh_deadline) &&
bb3b621a Ren Mingxin 2013-11-11 108 shost->eh_deadline > -1)
b4562022 Hannes Reinecke 2013-10-23 109 return 0;
b4562022 Hannes Reinecke 2013-10-23 110
b4562022 Hannes Reinecke 2013-10-23 111 return 1;
b4562022 Hannes Reinecke 2013-10-23 112 }
b4562022 Hannes Reinecke 2013-10-23 113
^1da177e Linus Torvalds 2005-04-16 114 /**
e494f6a7 Hannes Reinecke 2013-11-11 115 * scmd_eh_abort_handler - Handle command aborts
e494f6a7 Hannes Reinecke 2013-11-11 116 * @work: command to be aborted.
e494f6a7 Hannes Reinecke 2013-11-11 117 */
07311267 Hannes Reinecke 2017-04-04 118 int
07311267 Hannes Reinecke 2017-04-04 119 scmd_eh_abort_handler(struct scsi_cmnd *scmd)
e494f6a7 Hannes Reinecke 2013-11-11 @120 {
e494f6a7 Hannes Reinecke 2013-11-11 121 struct scsi_device *sdev = scmd->device;
e494f6a7 Hannes Reinecke 2013-11-11 122 int rtn;
e494f6a7 Hannes Reinecke 2013-11-11 123
e494f6a7 Hannes Reinecke 2013-11-11 124 if (scsi_host_eh_past_deadline(sdev->host)) {
e494f6a7 Hannes Reinecke 2013-11-11 125 SCSI_LOG_ERROR_RECOVERY(3,
e494f6a7 Hannes Reinecke 2013-11-11 126 scmd_printk(KERN_INFO, scmd,
470613b4 Hannes Reinecke 2015-01-08 127 "eh timeout, not aborting\n"));
07311267 Hannes Reinecke 2017-04-04 128 return FAILED;

:::::: The code at line 120 was first introduced by commit
:::::: e494f6a728394ab0df194342549ee20e6f0752df [SCSI] improved eh timeout handler

:::::: TO: Hannes Reinecke <hare@suse.de>
:::::: CC: James Bottomley <JBottomley@Parallels.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6576 bytes --]