From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
Bart van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv6 0/8] SCSI EH cleanup
Date: Thu, 6 Apr 2017 15:36:28 +0200 [thread overview]
Message-ID: <1491485796-44411-1-git-send-email-hare@suse.de> (raw)
Hi all,
this is a resend of a small patchset for cleaning up SCSI EH.
Primary goal is to make asynchronous aborts mandatory; there hasn't
been a single report so far where asynchronous abort won't work, so
the 'no_async_abort' flag has never been used and will be removed
with this patchset.
Additionally there's a cleanup to detect retries of failed commands and
to inline commands aborts.
I've also included the patch to correctly reset the media access
timeout counter to avoid it being triggered inadvertedly by several
commands timing out for the same device.
As usual, comments and reviews are welcome.
Changes to v1:
- Include reviews from Christoph
Changes to v2:
- Include reviews from Bart
- Add medium access timeout patch
Changes to v3:
- Add patch to inline command abort as per suggestion from Christoph
- Drop patch to not escalate failed EH commands
Changes to v4:
- Split off sdrv->eh_action into two functions
Changes to v5:
- Simplify 'scsi: inline command aborts'
- Add Reviewed-by tags
Christoph Hellwig (1):
libsas: allow async aborts
Hannes Reinecke (7):
scsi_error: count medium access timeout only once per EH run
sd: Return SUCCESS in sd_eh_action() after device offline
scsi: always send command aborts
scsi: make eh_eflags persistent
scsi: make scsi_eh_scmd_add() always succeed
scsi: make asynchronous aborts mandatory
scsi: inline command aborts
Documentation/scsi/scsi_eh.txt | 30 ++---
drivers/scsi/libsas/sas_scsi_host.c | 5 -
drivers/scsi/scsi.c | 2 -
drivers/scsi/scsi_error.c | 213 ++++++++++++------------------------
drivers/scsi/scsi_lib.c | 6 +-
drivers/scsi/scsi_priv.h | 4 +-
drivers/scsi/sd.c | 29 ++++-
drivers/scsi/sd.h | 1 +
include/scsi/scsi_cmnd.h | 1 -
include/scsi/scsi_driver.h | 1 +
include/scsi/scsi_eh.h | 1 +
include/scsi/scsi_host.h | 5 -
12 files changed, 113 insertions(+), 185 deletions(-)
--
1.8.5.6
next reply other threads:[~2017-04-06 13:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 13:36 Hannes Reinecke [this message]
2017-04-06 13:36 ` [PATCHv6 1/8] scsi_error: count medium access timeout only once per EH run Hannes Reinecke
2017-04-06 13:36 ` [PATCHv6 2/8] sd: Return SUCCESS in sd_eh_action() after device offline Hannes Reinecke
2017-04-10 23:54 ` Bart Van Assche
2017-04-06 13:36 ` [PATCHv6 3/8] scsi: always send command aborts Hannes Reinecke
2017-04-10 23:56 ` Bart Van Assche
2017-04-06 13:36 ` [PATCHv6 4/8] libsas: allow async aborts Hannes Reinecke
2017-04-06 13:36 ` [PATCHv6 5/8] scsi: make eh_eflags persistent Hannes Reinecke
2017-04-10 23:58 ` Bart Van Assche
2017-04-06 13:36 ` [PATCHv6 6/8] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2017-04-06 13:36 ` [PATCHv6 7/8] scsi: make asynchronous aborts mandatory Hannes Reinecke
2017-04-06 13:36 ` [PATCHv6 8/8] scsi: inline command aborts Hannes Reinecke
2017-04-10 7:53 ` Christoph Hellwig
2017-04-11 0:19 ` Bart Van Assche
2017-04-20 2:14 ` Martin K. Petersen
2017-04-24 12:41 ` Hannes Reinecke
2017-04-06 17:09 ` [PATCHv6 0/8] SCSI EH cleanup Martin K. Petersen
2017-04-06 17:52 ` Benjamin Block
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491485796-44411-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox