Re: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region

Sagi Grimberg
2017-04-04T10:42:57Z

> +static void setup_memwin_p2pmem(struct adapter *adap)
> +{
> + unsigned int mem_base = t4_read_reg(adap, CIM_EXTMEM2_BASE_ADDR_A);
> + unsigned int mem_size = t4_read_reg(adap, CIM_EXTMEM2_ADDR_SIZE_A);
> +
> + if (!use_p2pmem)
> + return;

This is weird, why even call this if !use_p2pmem?

> +static int init_p2pmem(struct adapter *adapter)
> +{
> + unsigned int mem_size = t4_read_reg(adapter, CIM_EXTMEM2_ADDR_SIZE_A);
> + struct p2pmem_dev *p;
> + int rc;
> + struct resource res;
> +
> + if (!mem_size || !use_p2pmem)
> + return 0;

Again, weird...