From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>, "hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH 2/9] sd: Fix functions description
Date: Fri, 21 Apr 2017 17:28:30 +0000 [thread overview]
Message-ID: <1492795708.2550.19.camel@sandisk.com> (raw)
In-Reply-To: <20170421091649.25287-3-damien.lemoal@wdc.com>
On Fri, 2017-04-21 at 18:16 +0900, damien.lemoal@wdc.com wrote:
> - * Returns 0 if successful. Returns a negated errno value in case
> - * of error.
> + * Returns 0 if successful. Returns a negated errno value in case
> + * of error.
Hello Damien,
The argument name fixes are definitely welcome in my opinion. But I see
that this patch not only fixes argument names and function descriptions
but also includes whitespace-only changes like the above. Sorry but I
don't like whitespace-only changes ...
Bart.
next prev parent reply other threads:[~2017-04-21 18:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 9:16 [PATCH 0/9] scsi: sd/sd_zbc cleanup and improvements damien.lemoal
2017-04-21 9:16 ` [PATCH 1/9] sd: Remove white space before EOL damien.lemoal
2017-04-21 17:22 ` Bart Van Assche
2017-04-24 0:14 ` Damien Le Moal
2017-04-21 9:16 ` [PATCH 2/9] sd: Fix functions description damien.lemoal
2017-04-21 17:28 ` Bart Van Assche [this message]
2017-04-24 0:21 ` Damien Le Moal
2017-04-21 9:16 ` [PATCH 3/9] sd: Remove unecessary variable in sd_done() damien.lemoal
2017-04-21 18:42 ` James Bottomley
2017-04-24 0:25 ` Damien Le Moal
2017-04-21 9:16 ` [PATCH 4/9] sd: Improve sd_completed_bytes damien.lemoal
2017-04-21 9:16 ` [PATCH 5/9] sd: Cleanup sd_done sense data handling damien.lemoal
2017-04-21 18:41 ` Bart Van Assche
2017-04-24 0:23 ` Damien Le Moal
2017-04-21 9:16 ` [PATCH 6/9] scsi: Improve scsi_get_sense_info_fld damien.lemoal
2017-04-21 16:58 ` Bart Van Assche
2017-04-23 23:59 ` Damien Le Moal
2017-04-21 9:16 ` [PATCH 7/9] sd_zbc: Rename sd_zbc_setup_write_cmnd damien.lemoal
2017-04-21 17:07 ` Bart Van Assche
2017-04-24 0:00 ` Damien Le Moal
2017-04-21 9:16 ` [PATCH 8/9] sd_zbc: Remove superfluous assignments damien.lemoal
2017-04-21 9:16 ` [PATCH 9/9] sd_zbc: Do not write lock zones for reset damien.lemoal
2017-04-21 17:15 ` Bart Van Assche
2017-04-24 0:11 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492795708.2550.19.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=Damien.LeMoal@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox