From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v5 0/4] Avoid that __scsi_remove_device() hangs
Date: Wed, 26 Apr 2017 18:50:59 +0000 [thread overview]
Message-ID: <1493232656.2632.7.camel@sandisk.com> (raw)
In-Reply-To: <20170425205354.21181-1-bart.vanassche@sandisk.com>
On Tue, 2017-04-25 at 13:53 -0700, Bart Van Assche wrote:
> __scsi_remove_device() hangs if it is waiting for the SYNCHRONIZE CACHE
> command submitted by the sd driver to finish if the block layer queue is
> stopped and does not get restarted. This patch series avoids that that
> hang occurs.
> [ ... ]
Hello Martin and James,
Even with this version of this patch series there is still a lockup possible,
namely if the sd events checker submits a TUR while a SCSI device is blocked
and before __scsi_remove_device() calls device_del(). The latter function
namely waits for sd_check_events() to finish.
Bart.
prev parent reply other threads:[~2017-04-26 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:53 [PATCH v5 0/4] Avoid that __scsi_remove_device() hangs Bart Van Assche
2017-04-25 20:53 ` [PATCH v5 1/4] Introduce scsi_start_queue() Bart Van Assche
2017-04-25 20:53 ` [PATCH v5 2/4] Introduce scsi_execute_async() Bart Van Assche
2017-04-25 20:53 ` [PATCH v5 3/4] sd: Make synchronize cache upon shutdown asynchronous Bart Van Assche
2017-04-25 20:53 ` [PATCH v5 4/4] Avoid that __scsi_remove_device() hangs Bart Van Assche
2017-04-26 18:50 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493232656.2632.7.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox