Re: [PATCH v2] lpfc: Fix panic on BFS configuration.

Martin K. Petersen
2017-04-27T16:23:31Z

James,

Please run checkpatch on your submissions.

> This issue was introduced by this patch:
> http://www.spinics.net/lists/linux-scsi/msg105908.html
> which is in the stable pools with commit id:
> 96418b5e2c8867da3279d877f5d1ffabfe460c3d

This information needs to go in the tag section:

Fixes: 96418b5e2c88 ("scsi: lpfc: Fix eh_deadline setting for sli3 adapters.")

> This patch was cut against the scsi.git tree, misc branch and should
> be pulled in via the scsi tree.
>
> This patch needs to be applied to the stable trees where ever the
> introducing patch exists.

The above commentary needs to go below the --- separator.

And finally:

drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_handle_deferred_eratt’:
drivers/scsi/lpfc/lpfc_init.c:1428:3: error: ‘rc’ undeclared (first use in this function)
rc = lpfc_sli_chipset_init(phba);
^
drivers/scsi/lpfc/lpfc_init.c:1428:3: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/lpfc/lpfc_init.c:1430:4: warning: ‘return’ with a value, in function returning void [enabled by default]
return (uint64_t)-1;
^
make[3]: *** [drivers/scsi/lpfc/lpfc_init.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/scsi/lpfc] Error 2
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

--
Martin K. Petersen Oracle Linux Engineering