From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hare@suse.de" <hare@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>
Subject: Re: [PATCH] libfc: do not flood console with messages 'libfc: queue full ...'
Date: Thu, 27 Apr 2017 16:07:29 +0000 [thread overview]
Message-ID: <1493309247.2625.4.camel@sandisk.com> (raw)
In-Reply-To: <1493303103-113774-1-git-send-email-hare@suse.de>
On Thu, 2017-04-27 at 16:25 +0200, Hannes Reinecke wrote:
> @@ -1896,11 +1899,11 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
>
> if (!fc_fcp_lport_queue_ready(lport)) {
> if (lport->qfull) {
> - fc_fcp_can_queue_ramp_down(lport);
> - shost_printk(KERN_ERR, lport->host,
> - "libfc: queue full, "
> - "reducing can_queue to %d.\n",
> - lport->host->can_queue);
> + if (fc_fcp_can_queue_ramp_down(lport))
> + shost_printk(KERN_ERR, lport->host,
> + "libfc: queue full, "
> + "reducing can_queue to %d.\n",
> + lport->host->can_queue);
> }
> rc = SCSI_MLQUEUE_HOST_BUSY;
> goto out;
Hello Hannes,
Although this would have been a good opportunity to join the log message
that has been split over two lines:
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
next prev parent reply other threads:[~2017-04-27 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 14:25 [PATCH] libfc: do not flood console with messages 'libfc: queue full ...' Hannes Reinecke
2017-04-27 16:07 ` Bart Van Assche [this message]
2017-05-08 8:48 ` Johannes Thumshirn
2017-05-09 1:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493309247.2625.4.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox