* target: fixup error message in target_tg_pt_gp_alua_access_type_store()
@ 2017-04-27 14:17 Hannes Reinecke
2017-04-27 16:14 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2017-04-27 14:17 UTC (permalink / raw)
To: Nic Bellinger
Cc: Bart van Assche, target-devel, linux-scsi, Hannes Reinecke,
Hannes Reinecke
When setting up a target the error message:
Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0
is displayed.
Apparently concatenation doesn't work in a string; one should be using
implicit string concatenation here.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
drivers/target/target_core_configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index dc654fe..1f229cc 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2559,9 +2559,9 @@ static ssize_t target_tg_pt_gp_alua_support_##_name##_store( \
int ret; \
\
if (!t->tg_pt_gp_valid_id) { \
- pr_err("Unable to do set ##_name ALUA state on non" \
+ pr_err("Unable to do set " #_name " ALUA state on non" \
" valid tg_pt_gp ID: %hu\n", \
- t->tg_pt_gp_valid_id); \
+ t->tg_pt_gp_valid_id); \
return -EINVAL; \
} \
\
--
1.8.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: target: fixup error message in target_tg_pt_gp_alua_access_type_store()
2017-04-27 14:17 target: fixup error message in target_tg_pt_gp_alua_access_type_store() Hannes Reinecke
@ 2017-04-27 16:14 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2017-04-27 16:14 UTC (permalink / raw)
To: hare@suse.de, nab@daterainc.com
Cc: linux-scsi@vger.kernel.org, hare@suse.com,
target-devel@vger.kernel.org
On Thu, 2017-04-27 at 16:17 +0200, Hannes Reinecke wrote:
> When setting up a target the error message:
>
> Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0
>
> is displayed.
> Apparently concatenation doesn't work in a string; one should be using
> implicit string concatenation here.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/target/target_core_configfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index dc654fe..1f229cc 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -2559,9 +2559,9 @@ static ssize_t target_tg_pt_gp_alua_support_##_name##_store( \
> int ret; \
> \
> if (!t->tg_pt_gp_valid_id) { \
> - pr_err("Unable to do set ##_name ALUA state on non" \
> + pr_err("Unable to do set " #_name " ALUA state on non" \
> " valid tg_pt_gp ID: %hu\n", \
> - t->tg_pt_gp_valid_id); \
> + t->tg_pt_gp_valid_id); \
> return -EINVAL; \
> } \
Hello Hannes,
The second change breaks the alignment of the backspaces which is unfortunate.
Otherwise this patch looks fine to me.
Bart. \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-27 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-27 14:17 target: fixup error message in target_tg_pt_gp_alua_access_type_store() Hannes Reinecke
2017-04-27 16:14 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox