Re: target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

On Thu, 2017-04-27 at 16:17 +0200, Hannes Reinecke wrote:
> When setting up an ALUA target port group with an invalid ID the
> error message
> 
> kstrtoul() returned -22 for tg_pt_gp_id
> 
> is displayed, which is not really helpful.
> Convert it to something sane.
> 
> Reviewed-by: Hannes Reinecke <hare@suse.com>

Did you perhaps mean "Signed-off-by"?

>  drivers/target/target_core_configfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index 1f229cc..27f7411 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -2691,8 +2691,8 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
>  
>  	ret = kstrtoul(page, 0, &tg_pt_gp_id);
>  	if (ret < 0) {
> -		pr_err("kstrtoul() returned %d for"
> -			" tg_pt_gp_id\n", ret);
> +		pr_err("ALUA tg_pt_gp_id: invalid value '%s' for"
> +			" tg_pt_gp_id\n", page);
>  		return ret;
>  	}
>  	if (tg_pt_gp_id > 0x0000ffff) {

Although this patch looks fine to me, this would have been a good opportunity
to join the two parts of the error message such that these appear on the same
source code line.

Bart.