* target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
@ 2017-04-27 14:17 Hannes Reinecke
2017-04-27 16:17 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2017-04-27 14:17 UTC (permalink / raw)
To: Nic Bellinger; +Cc: Bart van Assche, target-devel, linux-scsi, Hannes Reinecke
When setting up an ALUA target port group with an invalid ID the
error message
kstrtoul() returned -22 for tg_pt_gp_id
is displayed, which is not really helpful.
Convert it to something sane.
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
drivers/target/target_core_configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 1f229cc..27f7411 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2691,8 +2691,8 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
ret = kstrtoul(page, 0, &tg_pt_gp_id);
if (ret < 0) {
- pr_err("kstrtoul() returned %d for"
- " tg_pt_gp_id\n", ret);
+ pr_err("ALUA tg_pt_gp_id: invalid value '%s' for"
+ " tg_pt_gp_id\n", page);
return ret;
}
if (tg_pt_gp_id > 0x0000ffff) {
--
1.8.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
2017-04-27 14:17 target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store() Hannes Reinecke
@ 2017-04-27 16:17 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2017-04-27 16:17 UTC (permalink / raw)
To: hare@suse.de, nab@daterainc.com
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
On Thu, 2017-04-27 at 16:17 +0200, Hannes Reinecke wrote:
> When setting up an ALUA target port group with an invalid ID the
> error message
>
> kstrtoul() returned -22 for tg_pt_gp_id
>
> is displayed, which is not really helpful.
> Convert it to something sane.
>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
Did you perhaps mean "Signed-off-by"?
> drivers/target/target_core_configfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index 1f229cc..27f7411 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -2691,8 +2691,8 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
>
> ret = kstrtoul(page, 0, &tg_pt_gp_id);
> if (ret < 0) {
> - pr_err("kstrtoul() returned %d for"
> - " tg_pt_gp_id\n", ret);
> + pr_err("ALUA tg_pt_gp_id: invalid value '%s' for"
> + " tg_pt_gp_id\n", page);
> return ret;
> }
> if (tg_pt_gp_id > 0x0000ffff) {
Although this patch looks fine to me, this would have been a good opportunity
to join the two parts of the error message such that these appear on the same
source code line.
Bart.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-27 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-27 14:17 target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store() Hannes Reinecke
2017-04-27 16:17 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox