* [PATCH] target: fixup error message in target_tg_pt_gp_alua_access_type_store()
@ 2017-04-28 8:03 Hannes Reinecke
2017-05-02 5:16 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2017-04-28 8:03 UTC (permalink / raw)
To: Nic Bellinger
Cc: Bart van Assche, target-devel, linux-scsi, Hannes Reinecke,
Hannes Reinecke
When setting up a target the error message:
Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0
is displayed.
Apparently concatenation doesn't work in a string; one should be using
implicit string concatenation here.
Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
---
drivers/target/target_core_configfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 54b36c9..e8850ae 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2507,7 +2507,7 @@ static ssize_t target_tg_pt_gp_alua_access_type_store(struct config_item *item,
int ret; \
\
if (!t->tg_pt_gp_valid_id) { \
- pr_err("Unable to do set ##_name ALUA state on non" \
+ pr_err("Unable to do set " #_name " ALUA state on non" \
" valid tg_pt_gp ID: %hu\n", \
t->tg_pt_gp_valid_id); \
return -EINVAL; \
--
1.8.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target: fixup error message in target_tg_pt_gp_alua_access_type_store()
2017-04-28 8:03 [PATCH] target: fixup error message in target_tg_pt_gp_alua_access_type_store() Hannes Reinecke
@ 2017-05-02 5:16 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2017-05-02 5:16 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Nic Bellinger, Bart van Assche, target-devel, linux-scsi,
Hannes Reinecke
On Fri, 2017-04-28 at 10:03 +0200, Hannes Reinecke wrote:
> When setting up a target the error message:
>
> Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0
>
> is displayed.
> Apparently concatenation doesn't work in a string; one should be using
> implicit string concatenation here.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
> ---
> drivers/target/target_core_configfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Thanks Hannes.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-02 5:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 8:03 [PATCH] target: fixup error message in target_tg_pt_gp_alua_access_type_store() Hannes Reinecke
2017-05-02 5:16 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox