* [PATCH] target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
@ 2017-04-28 8:04 Hannes Reinecke
2017-04-28 17:21 ` Bart Van Assche
2017-05-02 5:17 ` Nicholas A. Bellinger
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Reinecke @ 2017-04-28 8:04 UTC (permalink / raw)
To: Nic Bellinger; +Cc: Bart van Assche, target-devel, linux-scsi, Hannes Reinecke
When setting up an ALUA target port group with an invalid ID the
error message
kstrtoul() returned -22 for tg_pt_gp_id
is displayed, which is not really helpful.
Convert it to something sane.
And while we're at it, join the messages onto a single line.
Signed-by: Hannes Reinecke <hare@suse.com>
---
drivers/target/target_core_configfs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index e8850ae..f62130f 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2639,13 +2639,13 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
ret = kstrtoul(page, 0, &tg_pt_gp_id);
if (ret < 0) {
- pr_err("kstrtoul() returned %d for"
- " tg_pt_gp_id\n", ret);
+ pr_err("ALUA tg_pt_gp_id: invalid value '%s' for tg_pt_gp_id\n",
+ page);
return ret;
}
if (tg_pt_gp_id > 0x0000ffff) {
- pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum:"
- " 0x0000ffff\n", tg_pt_gp_id);
+ pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum: 0x0000ffff\n",
+ tg_pt_gp_id);
return -EINVAL;
}
--
1.8.5.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
2017-04-28 8:04 [PATCH] target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store() Hannes Reinecke
@ 2017-04-28 17:21 ` Bart Van Assche
2017-05-02 5:17 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2017-04-28 17:21 UTC (permalink / raw)
To: hare@suse.de, nab@daterainc.com
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
On Fri, 2017-04-28 at 10:04 +0200, Hannes Reinecke wrote:
> When setting up an ALUA target port group with an invalid ID the
> error message
>
> kstrtoul() returned -22 for tg_pt_gp_id
>
> is displayed, which is not really helpful.
> Convert it to something sane.
> And while we're at it, join the messages onto a single line.
Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
2017-04-28 8:04 [PATCH] target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store() Hannes Reinecke
2017-04-28 17:21 ` Bart Van Assche
@ 2017-05-02 5:17 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas A. Bellinger @ 2017-05-02 5:17 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: Nic Bellinger, Bart van Assche, target-devel, linux-scsi
On Fri, 2017-04-28 at 10:04 +0200, Hannes Reinecke wrote:
> When setting up an ALUA target port group with an invalid ID the
> error message
>
> kstrtoul() returned -22 for tg_pt_gp_id
>
> is displayed, which is not really helpful.
> Convert it to something sane.
> And while we're at it, join the messages onto a single line.
>
> Signed-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/target/target_core_configfs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Applied.
Thanks Hannes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-02 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 8:04 [PATCH] target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store() Hannes Reinecke
2017-04-28 17:21 ` Bart Van Assche
2017-05-02 5:17 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox