From: Zhou Zhengping <johnzzpcrystal@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: hare@suse.de, James.Bottomley@hansenpartnership.com,
Zhou Zhengping <johnzzpcrystal@gmail.com>
Subject: [PATCH]scsi: megaraid_sas: fix raid card hotswap failure
Date: Sun, 30 Apr 2017 02:11:11 +0800 [thread overview]
Message-ID: <1493489471-4848-1-git-send-email-johnzzpcrystal@gmail.com> (raw)
In-Reply-To: <1493372584-1204-1-git-send-email-johnzzpcrystal@gmail.com>
When a scsi_device is unpluged from scsi controller, if the
scsi_device is still be used by application layer,it won't be
released until users release it. In this case, scsi_device_remove just
set the scsi_device's state to be SDEV_DEL. But if you plug the disk
just before the old scsi_device is released, then there will be two
scsi_device structures in scsi_host->__devices. when the next unpluging
event happens,some low-level drivers will check whether the scsi_device
has been added to host (for example, the megaraid sas series controller)
by calling scsi_device_lookup(call __scsi_device_lookup) in function
megasas_aen_polling.__scsi_device_lookup will return the first scsi_device.
Because its state is SDEV_DEL, the scsi_device_lookup will return NULL
finally, making the low-level driver assume that the scsi_device has been
removed,and won't call scsi_device_remove,which will lead the
failure of hot swap.
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Tested-and-reported-by: Zeng Rujia <ZengRujia@sangfor.com.cn>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195607
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
drivers/scsi/scsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 7bfbcfa..61cdd99 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -763,6 +763,8 @@ struct scsi_device *__scsi_device_lookup(struct Scsi_Host *shost,
struct scsi_device *sdev;
list_for_each_entry(sdev, &shost->__devices, siblings) {
+ if (sdev->sdev_state == SDEV_DEL)
+ continue;
if (sdev->channel == channel && sdev->id == id &&
sdev->lun ==lun)
return sdev;
--
1.8.3.1
next prev parent reply other threads:[~2017-04-29 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 9:43 [PATCH] MegaRAID SAS: Raidcard hotswap wouldn't work if the device's fd is held in userspace Zhou Zhengping
2017-04-28 13:34 ` Hannes Reinecke
2017-04-29 18:11 ` Zhou Zhengping [this message]
2017-05-09 1:38 ` [PATCH]scsi: megaraid_sas: fix raid card hotswap failure Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493489471-4848-1-git-send-email-johnzzpcrystal@gmail.com \
--to=johnzzpcrystal@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox