From: Arnd Bergmann <arnd@arndb.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>
Cc: linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [PATCH v2] scsi: pmcraid: Remove usage of struct timeval
Date: Wed, 25 Feb 2015 09:41:14 +0100 [thread overview]
Message-ID: <14946525.goxAvFt5IB@wuerfel> (raw)
In-Reply-To: <20150225021921.GA2890@tinar>
On Wednesday 25 February 2015 07:49:21 Tina Ruchandani wrote:
> struct timeval will have its tv_sec field overflow on 32-bit systems
> in year 2038 and beyond. This patch removes the usage of struct timeval
> and instead uses 64-bit ktime_t to get the current milliseconds
> to populate pmcraid_timestamp_data.
>
> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I notice that this patch also increases the accuracy of the timestamp
from seconds to milliseconds, where the original code ignores the
sub-second portion of the timeval.
Doing this will make the the function a little slower, but I have
verified that it is only called for probe, reset and config-change,
all of which are not timing critical.
Arnd
prev parent reply other threads:[~2015-02-25 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 2:19 [PATCH v2] scsi: pmcraid: Remove usage of struct timeval Tina Ruchandani
2015-02-25 8:41 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14946525.goxAvFt5IB@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox