From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "emilne@redhat.com" <emilne@redhat.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sd: fix sysfs writes to "provisioning_mode" and "zeroing_mode"
Date: Mon, 15 May 2017 21:14:10 +0000 [thread overview]
Message-ID: <1494882849.2567.6.camel@sandisk.com> (raw)
In-Reply-To: <1494882178.1081.43.camel@localhost.localdomain>
On Mon, 2017-05-15 at 17:02 -0400, Ewan D. Milne wrote:
> I think it's the '\n' that actually causes the problem.
Agreed, and that's why I proposed to strip trailing whitespace.
> But, what I think we should do is use the same technique everywhere.
If you have a look at the block layer you will see that the block layer
sysfs code is already using strim() and strstrip().
> So, are you suggesting we change all the other sysfs store routines?
I will leave it to Martin and James to comment on this.
Bart.
next prev parent reply other threads:[~2017-05-15 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 19:13 [PATCH] sd: fix sysfs writes to "provisioning_mode" and "zeroing_mode" Ewan D. Milne
2017-05-15 20:14 ` Bart Van Assche
2017-05-15 21:02 ` Ewan D. Milne
2017-05-15 21:14 ` Bart Van Assche [this message]
2017-05-15 21:18 ` Martin K. Petersen
2017-05-16 12:52 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494882849.2567.6.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox