From: James Bottomley <jejb@linux.vnet.ibm.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: remove useless variable assignment
Date: Wed, 17 May 2017 21:39:58 -0700 [thread overview]
Message-ID: <1495082398.2840.14.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170518003043.GA5664@embeddedgus>
On Wed, 2017-05-17 at 19:30 -0500, Gustavo A. R. Silva wrote:
> Remove this assignment once the value stored in variable _k_ is
> overwritten after a few lines.
>
> Addresses-Coverity-ID: 1226927
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/scsi/qlogicfas408.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qlogicfas408.c
> b/drivers/scsi/qlogicfas408.c
> index c3a9151..269440a 100644
> --- a/drivers/scsi/qlogicfas408.c
> +++ b/drivers/scsi/qlogicfas408.c
> @@ -329,7 +329,6 @@ static unsigned int ql_pcmd(struct scsi_cmnd
> *cmd)
> */
> if ((k = ql_wai(priv)))
> return (k << 16);
> - k = inb(qbase + 5); /* should be 0x10, bus
> service */
That doesn't look right to me. inb() is a statement which has an
effect on the I/O device regardless of whether the returned value is
used or discarded. In this case I think it's being used to clear
pending interrupts, so removing it will likely cause a phase error.
James
next prev parent reply other threads:[~2017-05-18 4:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 0:30 [PATCH] scsi: remove useless variable assignment Gustavo A. R. Silva
2017-05-18 4:39 ` James Bottomley [this message]
2017-05-18 17:41 ` Gustavo A. R. Silva
2017-06-10 21:12 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2017-05-18 1:00 Gustavo A. R. Silva
2017-06-07 20:27 Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495082398.2840.14.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).