From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hare@suse.de" <hare@suse.de>, "asavkov@redhat.com" <asavkov@redhat.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH] Use ctlr directly in rdac_failover_get()
Date: Fri, 19 May 2017 22:23:30 +0000 [thread overview]
Message-ID: <1495232608.2581.3.camel@sandisk.com> (raw)
In-Reply-To: <1495195574-27835-1-git-send-email-asavkov@redhat.com>
On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote:
> rdac_failover_get references struct rdac_controller as
> ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being
> inefficient this also introduces a null-pointer dereference as
> send_mode_select() sets ctlr->ms_sdev to NULL before calling
> rdac_failover_get():
>
> [ ... ]
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
Hello Artem,
Although this patch looks fine to me, please consider adding the "Fixes:" and
"Cc: <stable@vger.kernel.org>" tags.
Bart.
next prev parent reply other threads:[~2017-05-19 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 12:06 [PATCH] Use ctlr directly in rdac_failover_get() Artem Savkov
2017-05-19 22:23 ` Bart Van Assche [this message]
2017-05-20 7:58 ` [PATCH v2] " Artem Savkov
2017-05-21 6:54 ` Christoph Hellwig
2017-05-24 1:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495232608.2581.3.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=asavkov@redhat.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox