From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] lpfc: nvmet_fc: fix format string Date: Sat, 20 May 2017 17:43:34 -0700 Message-ID: <1495327414.2093.8.camel@perches.com> References: <20170519080447.1043039-1-arnd@arndb.de> <1495276127.27714.4.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:59524 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbdEUAnw (ORCPT ); Sat, 20 May 2017 20:43:52 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Arnd Bergmann Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Johannes Thumshirn , linux-scsi@vger.kernel.org, Linux Kernel Mailing List On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote: > On Sat, May 20, 2017 at 12:28 PM, Joe Perches wrote: > > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote: > > > The lpfc_nvmeio_data() tracing helper always takes a format string and > > > three additional arguments. > > > > No it doesn't. It takes a format and arguments. > > > > I don't disagree with the patch, just the characterization > > of the lpfc_mvmeio_data call in the commit message. > > I think my description is correct, it's just not obvious from > reading the code until you also look at the lpfc_debugfs_nvme_trc > prototype: OK, but more that's a mismatch between a function and its arguments and a different called function within it.