From: "Ewan D. Milne" <emilne@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled
Date: Wed, 31 May 2017 11:21:44 -0400 [thread overview]
Message-ID: <1496244104.4753.104.camel@localhost.localdomain> (raw)
In-Reply-To: <20170526165935.19543-1-martin.petersen@oracle.com>
On Fri, 2017-05-26 at 12:59 -0400, Martin K. Petersen wrote:
> It was not possible to enable both T10 PI and TGPS because they share
> the same byte in the INQUIRY response. Logically OR the TPGS value
> instead of using assignment.
>
> Reported-by: Ritika Srivastava <ritika.srivastava@oracle.com>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> ---
> drivers/scsi/scsi_debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 17249c3650fe..b945d187873f 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -1404,7 +1404,7 @@ static int resp_inquiry(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
> arr[4] = SDEBUG_LONG_INQ_SZ - 5;
> arr[5] = (int)have_dif_prot; /* PROTECT bit */
> if (sdebug_vpd_use_hostno == 0)
> - arr[5] = 0x10; /* claim: implicit TGPS */
> + arr[5] |= 0x10; /* claim: implicit TGPS */
> arr[6] = 0x10; /* claim: MultiP */
> /* arr[6] |= 0x40; ... claim: EncServ (enclosure services) */
> arr[7] = 0xa; /* claim: LINKED + CMDQUE */
Code is correct.
s/TGPS/TPGS in the subject line and in one place in the patch description.
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2017-05-31 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 16:59 [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled Martin K. Petersen
2017-05-31 15:05 ` Bart Van Assche
2017-05-31 15:21 ` Ewan D. Milne [this message]
2017-06-01 2:59 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496244104.4753.104.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox