From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 13/17] qla2xxx: Remove redundant code
Date: Wed, 31 May 2017 23:37:47 +0000 [thread overview]
Message-ID: <1496273866.2608.27.camel@sandisk.com> (raw)
In-Reply-To: <20170530175432.26984-14-himanshu.madhani@cavium.com>
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote:
> The reason for hard coding LUN ID to 0 is that, from the FC
> protocol perspective, ABTS does not have any knowledge of
> LUN ID. So, there is no reason for qla2xxx driver to
> manufacture the LUN ID.
Sorry but I think this is completely wrong. Are you aware that
target_submit_tmr() performs an exact match on the LUN specified as the fourth
argument? This patch will cause ABTS requests to be ignored that apply to
commands that have been submitted to another LUN than LUN 0.
Please note that I had proposed a better approach three months ago on the
target-devel mailing list and that I'm still waiting for someone from Cavium to
review these patches:
* [PATCH v6 09/33] target: Make it possible to specify I_T nexus for SCSI
abort (http://www.spinics.net/lists/target-devel/msg14534.html).
* [PATCH v6 10/33] tcm_qla2xxx: Let the target core look up the LUN of the
aborted cmd (http://www.spinics.net/lists/target-devel/msg14563.html).
Bart.
next prev parent reply other threads:[~2017-05-31 23:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 17:54 [PATCH v2 00/17] qla2xxx: Cleanup and minor fixes Himanshu Madhani
2017-05-30 17:54 ` [PATCH v2 01/17] qla2xxx: Allow ABTS RX, RIDA on ATIOQ for ISP83XX/27XX Himanshu Madhani
2017-05-31 23:42 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 02/17] qla2xxx: Replace usage of spin_lock with spin_lock_irqsave Himanshu Madhani
2017-05-31 23:43 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 03/17] qla2xxx: Retain loop test for fwdump length exceeding buffer length Himanshu Madhani
2017-05-31 23:44 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 04/17] qla2xxx: Include Exchange offload/Extended Login into FW dump Himanshu Madhani
2017-05-31 23:12 ` Bart Van Assche
2017-06-01 18:30 ` Madhani, Himanshu
2017-05-30 17:54 ` [PATCH v2 05/17] qla2xxx: Fix path recovery Himanshu Madhani
2017-05-31 23:44 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 06/17] tcm_qla2xxx: Do not allow aborted cmd to advance Himanshu Madhani
2017-05-31 23:49 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 07/17] qla2xxx: Use flag PFLG_DISCONNECTED Himanshu Madhani
2017-05-30 17:54 ` [PATCH v2 08/17] qla2xxx: Convert 32-bit LUN usage to 64-bit Himanshu Madhani
2017-05-31 23:18 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 09/17] qla2xxx: Fix name server relogin Himanshu Madhani
2017-05-30 17:54 ` [PATCH v2 10/17] qla2xxx: Cleanup debug message IDs Himanshu Madhani
2017-05-30 17:54 ` [PATCH v2 11/17] qla2xxx: Turn on FW option for exchange check Himanshu Madhani
2017-05-31 23:52 ` Bart Van Assche
2017-05-30 17:54 ` [PATCH v2 12/17] qla2xxx: Add ql2xiniexchg parameter Himanshu Madhani
2017-05-31 23:29 ` Bart Van Assche
2017-06-01 18:31 ` Madhani, Himanshu
2017-05-30 17:54 ` [PATCH v2 13/17] qla2xxx: Remove redundant code Himanshu Madhani
2017-05-31 23:37 ` Bart Van Assche [this message]
2017-06-01 18:33 ` Madhani, Himanshu
2017-05-30 17:54 ` [PATCH v2 14/17] qla2xxx: Remove redundant wait when target is stopped Himanshu Madhani
2017-05-30 17:54 ` [PATCH v2 15/17] qla2xxx: Accelerate SCSI BUSY status generation in target mode Himanshu Madhani
2017-05-31 23:39 ` Bart Van Assche
2017-06-01 18:32 ` Madhani, Himanshu
2017-05-30 17:54 ` [PATCH v2 16/17] qla2xxx: Remove unused irq_cmd_count field Himanshu Madhani
2017-05-30 17:54 ` [PATCH v2 17/17] qla2xxx: Remove extra register read Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496273866.2608.27.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox