From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v2 06/17] tcm_qla2xxx: Do not allow aborted cmd to advance. Date: Wed, 31 May 2017 23:49:45 +0000 Message-ID: <1496274583.2608.36.camel@sandisk.com> References: <20170530175432.26984-1-himanshu.madhani@cavium.com> <20170530175432.26984-7-himanshu.madhani@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from esa6.hgst.iphmx.com ([216.71.154.45]:34154 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdEaXtr (ORCPT ); Wed, 31 May 2017 19:49:47 -0400 In-Reply-To: <20170530175432.26984-7-himanshu.madhani@cavium.com> Content-Language: en-US Content-ID: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "James.Bottomley@HansenPartnership.com" , "himanshu.madhani@cavium.com" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Quinn Tran >=20 > In case of hardware queue full, commands can loop between > TCM stack and tcm_qla2xx shim layers for retry. While command > is waiting for retry, task mgmt can get ahead and abort the > cmmand that encountered queue full condition. Fix this by > dropping the command, if task mgmt has already started the > command free process. Although I think this is a check that should be performed by the target cor= e instead of each target driver: Reviewed-by: Bart Van Assche =