From: "Ewan D. Milne" <emilne@redhat.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state
Date: Wed, 28 Jun 2017 10:23:02 -0400 [thread overview]
Message-ID: <1498659782.10198.29.camel@localhost.localdomain> (raw)
In-Reply-To: <20170628073815.GA4185@linux-x5ow.site>
[ removed cc: stable from discussion ]
On Wed, 2017-06-28 at 09:38 +0200, Johannes Thumshirn wrote:
>
> Looks good,
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> Although we've been tampering with the target removal code for quite some
> time now, so I really have the gut feeling we haven't really fixed the
> root cause yet.
>
> I once tried building a regression test for this (with qemu hot plugging UAS
> devices) but that didn't really go far. Maybe we should add a scsi_target
> to scsi_debug and add some methods to toggle remove it again. Just to have
> a sensible unit test for that code path.
>
> Byte,
> Johannes
>
This specific crash is being encountered on systems connected to flaky
SANs, where the target rport repeatedly goes away. I was able to
reproduce it by inserting a delay before the "Scan LUN 0" comment in
__scsi_scan_target() with a message, and disabling the FC switch port.
-Ewan
next prev parent reply other threads:[~2017-06-28 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 18:55 [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state Ewan D. Milne
2017-06-27 21:26 ` Laurence Oberman
2017-06-28 1:09 ` Martin K. Petersen
2017-06-28 7:38 ` Johannes Thumshirn
2017-06-28 14:23 ` Ewan D. Milne [this message]
2017-07-01 20:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498659782.10198.29.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox