From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Subject: Re: [PATCH v2 01/15] qla2xxx: Combine Active command arrays.
Date: Tue, 11 Jul 2017 23:43:40 +0000 [thread overview]
Message-ID: <1499816619.2586.53.camel@wdc.com> (raw)
In-Reply-To: <20170614034730.15428-2-himanshu.madhani@cavium.com>
On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote:
> typedef struct srb {
> + /*
> + * Do not move cmd_type field, it needs to
> + * line up with qla_tgt_cmd->cmd_type
> + */
> + uint8_t cmd_type;
> + uint8_t pad[3];
Hello Himanshu,
Had I understood correctly that you had promised to rework the command
array merging such that a union is used instead of requiring certain
fields to be present at certain offsets (see also
https://www.spinics.net/lists/target-devel/msg15591.html)?
Bart.
next prev parent reply other threads:[~2017-07-11 23:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 3:47 [PATCH v2 00/15] qla2xxx: Add Target Multiqueue support Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 01/15] qla2xxx: Combine Active command arrays Himanshu Madhani
2017-07-11 23:43 ` Bart Van Assche [this message]
2017-07-12 0:39 ` Nicholas A. Bellinger
2017-07-12 4:41 ` Madhani, Himanshu
2017-06-14 3:47 ` [PATCH v2 02/15] qla2xxx: Preparation for Target MQ Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 03/15] qla2xxx: Enable Target Multi Queue Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 04/15] qla2xxx: Fix mailbox failure while deleting Queue pairs Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 05/15] qla2xxx: Add debug knob for user control workload Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 06/15] qla2xxx: Add fw_started flags to qpair Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 07/15] qla2xxx: move fields from qla_hw_data to qla_qpair Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 08/15] qla2xxx: use shadow register for ISP27XX Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 09/15] qla2xxx: Add function call to qpair for door bell Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 10/15] qla2xxx: Add debug logging routine for qpair Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 11/15] qla2xxx: Remove unused tgt_enable_64bit_addr flag Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 12/15] qla2xxx: Remove datasegs_per_cmd and datasegs_per_cont field Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 13/15] qla2xxx: Move target stat counters from vha to qpair Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 14/15] qla2xxx: Include Exchange offload/Extended Login into FW dump Himanshu Madhani
2017-06-14 3:47 ` [PATCH v2 15/15] qla2xxx: Update driver version to 9.01.00.00-k Himanshu Madhani
2017-07-08 1:48 ` [PATCH v2 00/15] qla2xxx: Add Target Multiqueue support Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499816619.2586.53.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox