From: Markus Elfring <Markus.Elfring@web.de>
To: Jianhao Xu <jianhao.xu@seu.edu.cn>, Zilin Guan <zilin@seu.edu.cn>,
linux-scsi@vger.kernel.org, Justin Tee <justin.tee@broadcom.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Paul Ely <paul.ely@broadcom.com>
Subject: Re: [PATCH 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port_post()
Date: Mon, 29 Dec 2025 10:09:04 +0100 [thread overview]
Message-ID: <149a576a-6a21-48c6-b121-b20c6173f7cb@web.de> (raw)
In-Reply-To: <20251229071515.155412-2-zilin@seu.edu.cn>
…
> Fix this by adding mempool_free() in the error path.
Please avoid duplicate source code here.
https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/scsi/lpfc/lpfc_init.c#L563-L564
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n262
Regards,
Markus
next prev parent reply other threads:[~2025-12-29 9:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 7:15 [PATCH 0/3] scsi: lpfc: Fix multiple memory leaks in error paths Zilin Guan
2025-12-29 7:15 ` [PATCH 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port_post() Zilin Guan
2025-12-29 9:09 ` Markus Elfring [this message]
2025-12-30 6:20 ` Zilin Guan
2025-12-30 7:28 ` [1/3] " Markus Elfring
2025-12-30 9:05 ` Zilin Guan
2026-01-05 9:53 ` [PATCH 1/3] " Dan Carpenter
2026-01-05 10:17 ` Dan Carpenter
2026-01-05 10:41 ` [1/3] " Markus Elfring
2025-12-29 7:15 ` [PATCH 2/3] scsi: lpfc: Fix memory leak in lpfc_sli4_driver_resource_setup() Zilin Guan
2025-12-29 7:15 ` [PATCH 3/3] scsi: lpfc: Fix memory leak in lpfc_cmpl_plogi_plogi_issue() Zilin Guan
2025-12-30 2:04 ` [PATCH 0/3] scsi: lpfc: Fix multiple memory leaks in error paths Justin Tee
2025-12-30 3:05 ` Zilin Guan
2026-01-05 9:56 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149a576a-6a21-48c6-b121-b20c6173f7cb@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=justin.tee@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paul.ely@broadcom.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox