From: James Bottomley <jejb@linux.vnet.ibm.com>
To: kbuild test robot <fengguang.wu@intel.com>,
Romain Perier <romain.perier@collabora.com>
Cc: kbuild-all@01.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Peter Senna Tschudin <peter.senna@collabora.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: megaraid: fix ifnullfree.cocci warnings
Date: Tue, 25 Jul 2017 08:48:45 -0700 [thread overview]
Message-ID: <1500997725.3689.14.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170725154005.GA50912@lkp-hsx03.lkp.intel.com>
On Tue, 2017-07-25 at 23:40 +0800, kbuild test robot wrote:
> drivers/scsi/megaraid/megaraid_sas_fusion.c:608:2-18: WARNING: NULL
> check before freeing functions like kfree, debugfs_remove,
> debugfs_remove_recursive or usb_free_urb is not needed. Maybe
> consider reorganizing relevant code to avoid passing NULL values.
> drivers/scsi/megaraid/megaraid_sas_fusion.c:629:2-18: WARNING: NULL
> check before freeing functions like kfree, debugfs_remove,
> debugfs_remove_recursive or usb_free_urb is not needed. Maybe
> consider reorganizing relevant code to avoid passing NULL values.
>
> NULL check before some freeing functions is not needed.
Hey, guys, we yelled at Markus Elfring for sending hundreds of patches
like this. The reason then was too much code churn for too little
value: the if() might be unnecessary but it really doesn't cost very
much in terms of execution time, so the code churn disadvantage greatly
outweighs any benefits.
The reason hasn't changed, so please stop this otherwise you're going
to turn the very valuable 0day test infrastructure into a thousand
patch spambot.
James
next prev parent reply other threads:[~2017-07-25 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201707252301.SY4YDAmp%fengguang.wu@intel.com>
2017-07-25 15:40 ` [PATCH] scsi: megaraid: fix ifnullfree.cocci warnings kbuild test robot
2017-07-25 15:48 ` James Bottomley [this message]
2017-07-25 15:40 ` kbuild test robot
2017-07-25 15:40 ` kbuild test robot
2020-12-11 10:16 Julia Lawall
2021-01-23 3:25 ` Martin K. Petersen
2021-01-27 4:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500997725.3689.14.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=kashyap.desai@broadcom.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=peter.senna@collabora.com \
--cc=romain.perier@collabora.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox