public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "michalx.potomski@intel.com" <michalx.potomski@intel.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
	"szymonx.mielczarek@intel.com" <szymonx.mielczarek@intel.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"vinholikatti@gmail.com" <vinholikatti@gmail.com>
Subject: Re: [PATCH v2] scsi: ufs: Implement Auto-Hibern8 setup
Date: Wed, 26 Jul 2017 15:25:34 +0000	[thread overview]
Message-ID: <1501082732.2671.5.camel@wdc.com> (raw)
In-Reply-To: <C8BF859FC3044844854B2CBA1ED115C1F99AFB@HASMSX111.ger.corp.intel.com>

On Tue, 2017-07-25 at 16:54 +0000, Potomski, MichalX wrote:
> On Tue, 2017-07-25 at 15:30 +0000, Bart Van Assche wrote:
> > Since I'm not familiar with the Auto-Hibern8 feature: what impact does it
> > have on command processing? Does it e.g. cause SCSI or TMF commands that
> > are
> > sent to the UFS device to be ignored, to fail or to time out?
> 
> Actually behavior should be transparent for all of the higher layers, since this
> shall be fully controlled by UFS Host, which will put UFS Device to Hibern8 state,
> when it has no ongoing commands to it for set up time. If there will be any command
> UFS Host should order the Device to exit Hibern8 mode and proceed normally.
> 
> Bottom line is that in model case, it shouldn't cause any of errors mentioned by you.
> There is possible throughput degradation in case, if transfers are sporadic in terms
> of timer, which we did set up, though. According to specification it also shouldn't affect
> Hibern8 states triggered by Power Management, nor any other functionality.

Hello Michal,

SCSI requests can not only be initiated by user space but also by the kernel
itself. Are SCSI UFS devices controlled by the SCSI disk (sd) driver? Will
SCSI requests submitted by sd_check_events() to a hibernated UFS device time
out and activate the SCSI error handler?

Thanks,

Bart.

  reply	other threads:[~2017-07-26 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  9:45 [PATCH v2] scsi: ufs: Implement Auto-Hibern8 setup Michal Potomski
2017-07-25 15:30 ` Bart Van Assche
2017-07-25 16:54   ` Potomski, MichalX
2017-07-26 15:25     ` Bart Van Assche [this message]
2017-07-27  9:15       ` Potomski, MichalX
2017-07-27 15:07         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501082732.2671.5.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michalx.potomski@intel.com \
    --cc=subhashj@codeaurora.org \
    --cc=szymonx.mielczarek@intel.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox