Re: [PATCHv2 0/6] hpsa legacy support

Hannes Reinecke
2017-08-15T06:22:12Z

On 08/15/2017 05:39 AM, Martin K. Petersen wrote:
>
> Hannes,
>
>> here's now the second attempt to add support for legacy boards, ie for
>> boards previously supported by cciss only. With this patchset the
>> hpsa driver should work with all Smart Array boards if the
>> 'hpsa_allow_any' module option is set, rendering the cciss driver
>> obsolete. Consequently I've added a patch to remove the cciss driver
>> and make 'hpsa' an alias to 'cciss'.
>
> How does the module alias solve the problem that hpsa_allow_any=1 needs
> to be added for users currently running cciss?
>
> I also fail to see what the point is of having an opt-in parameter when
> there is no alternative after cciss has been removed. It's a
> don't-be-broken switch.
>
Hmm ... considering this (and the fact that we now have the
->legacy_board switch) we can indeed remove that option.
Will be redoing the patchset.

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)