From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Don Brace <don.brace@microsemi.com>, Meelis Roos <mroos@linux.ee>,
linux-scsi@vger.kernel.org, Jeff Mahoney <jeffm@suse.com>,
Hannes Reinecke <hare@suse.com>
Subject: [PATCHv2 5/6] hpsa: handle unsupported devices more gracefully
Date: Mon, 14 Aug 2017 13:19:14 +0200 [thread overview]
Message-ID: <1502709555-15837-6-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1502709555-15837-1-git-send-email-hare@suse.de>
From: Jeff Mahoney <jeffm@suse.com>
Add a warning message if an unsupported device is found and the
hpsa_allow_any parameter is not set.
Also make the hpsa_allow_any parameter writeable once the hpsa
driver is loaded.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Acked-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index c90a83d..7168cec 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -85,7 +85,7 @@
static int hpsa_allow_any;
module_param(hpsa_allow_any, int, S_IRUGO|S_IWUSR);
MODULE_PARM_DESC(hpsa_allow_any,
- "Allow hpsa driver to access unknown HP Smart Array hardware");
+ "Allow hpsa driver to access unsupported HP Smart Array hardware");
static int hpsa_simple_mode;
module_param(hpsa_simple_mode, int, S_IRUGO|S_IWUSR);
MODULE_PARM_DESC(hpsa_simple_mode,
@@ -7314,6 +7314,7 @@ static int hpsa_lookup_board_id(struct pci_dev *pdev, u32 *board_id,
!hpsa_allow_any) {
dev_warn(&pdev->dev, "unrecognized board ID: "
"0x%08x, ignoring.\n", *board_id);
+ dev_warn(&pdev->dev, "This device may be enabled by loading the hpsa module with the hpsa_allow_any=1 option or by writing \"%s\" to /sys/bus/pci/drivers/hpsa/bind while the module is loaded. Please note that the driver is untested with this device and will result in an unsupported environment.\n", dev_name(&pdev->dev));
return -ENODEV;
}
if (legacy_board)
--
1.8.5.6
next prev parent reply other threads:[~2017-08-14 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 11:19 [PATCHv2 0/6] hpsa legacy support Hannes Reinecke
2017-08-14 11:19 ` [PATCHv2 1/6] hpsa: add support for legacy boards Hannes Reinecke
2017-08-14 11:19 ` [PATCHv2 2/6] hpsa: disable volume status check " Hannes Reinecke
2017-08-14 11:19 ` [PATCHv2 3/6] hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page Hannes Reinecke
2017-08-14 11:19 ` [PATCHv2 4/6] hpsa: do not print errors for unsupported report luns format Hannes Reinecke
2017-08-14 11:19 ` Hannes Reinecke [this message]
2017-08-14 11:19 ` [PATCHv2 6/6] cciss: Drop obsolete driver Hannes Reinecke
2017-08-14 18:10 ` Don Brace
2017-08-15 3:39 ` [PATCHv2 0/6] hpsa legacy support Martin K. Petersen
2017-08-15 6:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502709555-15837-6-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=don.brace@microsemi.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=jeffm@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox