From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "chaitra.basappa@broadcom.com" <chaitra.basappa@broadcom.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "sathya.prakash@broadcom.com" <sathya.prakash@broadcom.com>,
"sreekanth.reddy@broadcom.com" <sreekanth.reddy@broadcom.com>,
"suganath-prabu.subramani@broadcom.com"
<suganath-prabu.subramani@broadcom.com>,
"kashyap.desai@broadcom.com" <kashyap.desai@broadcom.com>
Subject: Re: smp-induced oops/NULL pointer dereference in mpt3sas, from kernel >= 4.11
Date: Thu, 17 Aug 2017 16:02:00 +0000 [thread overview]
Message-ID: <1502985717.2615.11.camel@wdc.com> (raw)
In-Reply-To: <155d5b2c7af4ae0cc6162baf6a52ef5b@mail.gmail.com>
On Thu, 2017-08-17 at 15:18 +0530, Chaitra Basappa wrote:
> We analyzed this issue and could figure out it is not because of driver,
> its because the "sense" field of the 'struct scsi_request' is not being
> populated properly from the upper layer.
> And this "sense" member is being referenced in our driver code for kernel
> versions >= 4.11 as shown below in the snippet:
> Whereas as for < 4.11 kernel version this "sense" member was referenced
> via 'struct request'
>
>
> static int
> _transport_smp_handler (.....) {
> .....
> .....
> > > memcpy(scsi_req(req)->sense, mpi_reply, sizeof(*mpi_reply));
>
> .....
> .....
> }
>
> And hence the NULL pointer dereference call trace is seen for the above
> chunk of mpt3sas. This needs to be addressed from upper layer, so please
> help us in getting this resolved.
Hello Chaitra,
Have you noticed the following e-mail thread: "[RFC PATCH 0/6] bsg: fix
regression resulting in panics when sending commands via BSG and some
sanity cleanups" (http://www.spinics.net/lists/linux-scsi/msg111724.html)?
Bart.
next prev parent reply other threads:[~2017-08-17 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 9:48 smp-induced oops/NULL pointer dereference in mpt3sas, from kernel >= 4.11 Chaitra Basappa
2017-08-17 16:02 ` Bart Van Assche [this message]
[not found] <3ba6084a-3404-18a4-3129-2539821b15df@linux.vnet.ibm.com>
2017-09-04 21:08 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502985717.2615.11.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=chaitra.basappa@broadcom.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox