Re: [PATCH 18/19] scsi_debug: Remove a set-but-not-used variable

Hannes Reinecke
2017-08-25T15:53:33Z

On 08/23/2017 11:40 PM, Bart Van Assche wrote:
> This patch avoids that gcc reports the following warning when
> building with W=1:
>
> drivers/scsi/scsi_debug.c:2264:15: warning: variable ?pcontrol? set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: Douglas Gilbert <dgilbert@interlog.com>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/scsi/scsi_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 3be980d47268..77a0335eb757 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -2261,7 +2261,7 @@ static int resp_ie_l_pg(unsigned char * arr)
> static int resp_log_sense(struct scsi_cmnd * scp,
> struct sdebug_dev_info * devip)
> {
> - int ppc, sp, pcontrol, pcode, subpcode, alloc_len, len, n;
> + int ppc, sp, pcode, subpcode, alloc_len, len, n;
> unsigned char arr[SDEBUG_MAX_LSENSE_SZ];
> unsigned char *cmd = scp->cmnd;
>
> @@ -2272,7 +2272,6 @@ static int resp_log_sense(struct scsi_cmnd * scp,
> mk_sense_invalid_fld(scp, SDEB_IN_CDB, 1, ppc ? 1 : 0);
> return check_condition_result;
> }
> - pcontrol = (cmd[2] & 0xc0) >> 6;
> pcode = cmd[2] & 0x3f;
> subpcode = cmd[3] & 0xff;
> alloc_len = get_unaligned_be16(cmd + 7);
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)