From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"brking@linux.vnet.ibm.com" <brking@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>, "hare@suse.com" <hare@suse.com>,
"jthumshirn@suse.de" <jthumshirn@suse.de>
Subject: Re: [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests
Date: Wed, 30 Aug 2017 23:03:11 +0000 [thread overview]
Message-ID: <1504134190.2526.63.camel@wdc.com> (raw)
In-Reply-To: <0df3b3b3-94f7-22bf-deb1-9c8b53d65ec5@linux.vnet.ibm.com>
On Wed, 2017-08-30 at 17:14 -0500, Brian King wrote:
> On 08/29/2017 07:07 PM, Bart Van Assche wrote:
> > If a pass-through request is submitted then blk_get_request()
> > initializes that request by calling scsi_initialize_rq(). Also
> > call this function for filesystem requests. Introduce
> > CMD_INITIALIZED to keep track of whether or not a request has
> > already been initialized.
>
> I applied these patches and was able to then re-apply your now reverted patch:
>
> 270065e92 - scsi-mq: Always unprepare before requeuing a request
>
> With this combination, I was still able to boot successfully on
> a Power system with ipr.
Hello Brian,
Thanks for testing! Sorry but a few minutes ago I found a bug in this
patch. I will repost this patch series.
Bart.
next prev parent reply other threads:[~2017-08-30 23:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 0:07 [PATCH v2 0/3] Improve requeuing behavior Bart Van Assche
2017-08-30 0:07 ` [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests Bart Van Assche
2017-08-30 8:29 ` Christoph Hellwig
2017-08-30 21:13 ` Bart Van Assche
2017-08-31 9:50 ` hch
2017-08-30 22:14 ` Brian King
2017-08-30 23:03 ` Bart Van Assche [this message]
2017-08-30 0:07 ` [PATCH v2 2/3] Improve requeuing behavior Bart Van Assche
2017-08-30 8:29 ` Christoph Hellwig
2017-08-30 0:07 ` [PATCH v2 3/3] Show .retries and .jiffies_at_alloc in debugfs Bart Van Assche
2017-08-30 8:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504134190.2526.63.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox