From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V3 1/2] scsi: sd: Fix sd_config_write_same()
Date: Tue, 12 Sep 2017 23:13:08 +0000 [thread overview]
Message-ID: <1505257987.2537.37.camel@wdc.com> (raw)
In-Reply-To: <20170905115536.2896-2-damien.lemoal@wdc.com>
On Tue, 2017-09-05 at 20:55 +0900, Damien Le Moal wrote:
> Reporting a maximum number of blocks that is not aligned on the device
> physical size would cause a large write same request to be split into
> physically unaligned chunks by __blkdev_issue_write_zeroes() and
> __blkdev_issue_write_same(), even if the caller of these functions took
> care to align its request to physical sectors.
>
> So make sure the maximum reported is aligned to the device physical
> block size. This is only an optional optimization for regular disks,
> but this is mandatory to avoid failure of large write same requests
> directed at sequential write required zones of host-managed ZBC disks.
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2017-09-12 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 11:55 [PATCH V3 0/2] sd fixes and cleanup Damien Le Moal
2017-09-05 11:55 ` [PATCH V3 1/2] scsi: sd: Fix sd_config_write_same() Damien Le Moal
2017-09-12 23:13 ` Bart Van Assche [this message]
2017-09-25 19:39 ` Martin K. Petersen
2017-09-05 11:55 ` [PATCH V3 2/2] scsi: sd: Use sectors_to_logical() Damien Le Moal
2017-09-12 23:15 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505257987.2537.37.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox