From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V5 07/14] scsi: sd_zbc: Initialize device request queue zoned data
Date: Mon, 2 Oct 2017 04:29:43 +0000 [thread overview]
Message-ID: <1506918581.24488.0.camel@wdc.com> (raw)
In-Reply-To: <1506374241.2641.20.camel@wdc.com>
On Mon, 2017-09-25 at 21:17 +0000, Bart Van Assche wrote:
> On Mon, 2017-09-25 at 15:14 +0900, Damien Le Moal wrote:
> > + return kzalloc_node(BITS_TO_LONGS(sdkp->nr_zones)
> > + * sizeof(unsigned long),
>
> Does this perhaps fit on one line?
>
> > +/**
> > + * sd_zbc_get_seq_zones - Parse report zones reply to identify sequential
> > zones
> > + * @sdkp: disk used
> > + * @buf: report reply buffer
> > + * @seq_zone_bitamp: bitmap of sequential zones to set
> > + * @zno: Zone number of the first zone in the report
>
> 'zno' is an input and output parameter but the above line only describes
> what
> happens with the value passed to sd_zbc_get_seq_zones(). I think we also
> need a
> description for the value of 'zno' upon return.
zno is not necessary since it can be calculated from the reported zone start
LBA. So I removed it in V6 to simplify.
--
Damien Le Moal
Western Digital
next prev parent reply other threads:[~2017-10-02 4:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:14 [PATCH V5 00/14] scsi-mq support for ZBC disks Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 01/14] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 02/14] scsi: sd_zbc: Fix comments and indentation Damien Le Moal
2017-10-02 23:01 ` Bart Van Assche
2017-09-25 6:14 ` [PATCH V5 03/14] scsi: sd_zbc: Rearrange code Damien Le Moal
2017-09-25 21:02 ` Bart Van Assche
2017-09-25 6:14 ` [PATCH V5 04/14] scsi: sd_zbc: Use well defined macros Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 05/14] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 06/14] block: Add zoned block device information to request queue Damien Le Moal
2017-09-25 10:05 ` Ming Lei
2017-09-25 21:06 ` Bart Van Assche
2017-09-25 6:14 ` [PATCH V5 07/14] scsi: sd_zbc: Initialize device request queue zoned data Damien Le Moal
2017-09-25 21:17 ` Bart Van Assche
2017-10-02 4:29 ` Damien Le Moal [this message]
2017-09-25 6:14 ` [PATCH V5 08/14] scsi: sd_zbc: Limit zone write locking to sequential zones Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 09/14] scsi: sd_zbc: Disable zone write locking with scsi-mq Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 10/14] block: mq-deadline: Add zoned block device data Damien Le Moal
2017-09-25 21:34 ` Bart Van Assche
2017-10-02 4:32 ` Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 11/14] blokc: mq-deadline: Introduce dispatch helpers Damien Le Moal
2017-09-25 21:44 ` Bart Van Assche
2017-09-25 6:14 ` [PATCH V5 12/14] block: mq-deadline: Introduce zone locking support Damien Le Moal
2017-09-25 22:00 ` Bart Van Assche
2017-10-02 4:36 ` Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 13/14] block: mq-deadline: Limit write request dispatch for zoned block devices Damien Le Moal
2017-09-25 22:06 ` Bart Van Assche
2017-10-02 4:38 ` Damien Le Moal
2017-09-25 6:14 ` [PATCH V5 14/14] block: do not set mq default scheduler Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506918581.24488.0.camel@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).