* [PATCH] scsi: eata: Remove unnecessary cpp_index check
@ 2017-10-08 21:47 Christos Gkekas
0 siblings, 0 replies; only message in thread
From: Christos Gkekas @ 2017-10-08 21:47 UTC (permalink / raw)
To: Dario Ballabio, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Cc: Christos Gkekas
Variable spp->cpp_index is unsigned so checking whether it is less than
zero is redundant.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/scsi/eata.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index 6501c33..53a8fcd 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -2332,12 +2332,11 @@ static irqreturn_t ihdlr(struct Scsi_Host *shost)
printk
("%s: ihdlr, spp->eoc == 0, irq %d, reg 0x%x, count %d.\n",
ha->board_name, irq, reg, ha->iocount);
- if (spp->cpp_index < 0 || spp->cpp_index >= shost->can_queue)
+ if (spp->cpp_index >= shost->can_queue)
printk
("%s: ihdlr, bad spp->cpp_index %d, irq %d, reg 0x%x, count %d.\n",
ha->board_name, spp->cpp_index, irq, reg, ha->iocount);
- if (spp->eoc == 0 || spp->cpp_index < 0
- || spp->cpp_index >= shost->can_queue)
+ if (spp->eoc == 0 || spp->cpp_index >= shost->can_queue)
goto handled;
/* Find the mailbox to be serviced on this board */
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-10-08 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-08 21:47 [PATCH] scsi: eata: Remove unnecessary cpp_index check Christos Gkekas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).