From: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
To: cleech@redhat.com, lduncan@suse.com
Cc: linux-scsi@vger.kernel.org,
Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Subject: [PATCH 01/10] be2iscsi: Fix boot flags in sysfs
Date: Tue, 10 Oct 2017 16:18:11 +0530 [thread overview]
Message-ID: <1507632500-26445-2-git-send-email-jitendra.bhivare@broadcom.com> (raw)
In-Reply-To: <1507632500-26445-1-git-send-email-jitendra.bhivare@broadcom.com>
The boot flags exported through sysfs was wrongly reverted to 2.
Use boot flag 3 required per spec.
Bit 0 Block valid flag
Bit 1 Firmware booting selected
Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
---
drivers/scsi/be2iscsi/be_main.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index b4542e7..56ae0f4 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -4917,6 +4917,13 @@ void beiscsi_start_boot_work(struct beiscsi_hba *phba, unsigned int s_handle)
schedule_work(&phba->boot_work);
}
+/**
+ * Boot flag info for iscsi-utilities
+ * Bit 0 Block valid flag
+ * Bit 1 Firmware booting selected
+ */
+#define BEISCSI_SYSFS_ISCSI_BOOT_FLAGS 3
+
static ssize_t beiscsi_show_boot_tgt_info(void *data, int type, char *buf)
{
struct beiscsi_hba *phba = data;
@@ -4972,7 +4979,7 @@ static ssize_t beiscsi_show_boot_tgt_info(void *data, int type, char *buf)
auth_data.chap.intr_secret);
break;
case ISCSI_BOOT_TGT_FLAGS:
- rc = sprintf(str, "2\n");
+ rc = sprintf(str, "%d\n", BEISCSI_SYSFS_ISCSI_BOOT_FLAGS);
break;
case ISCSI_BOOT_TGT_NIC_ASSOC:
rc = sprintf(str, "0\n");
@@ -5004,7 +5011,7 @@ static ssize_t beiscsi_show_boot_eth_info(void *data, int type, char *buf)
switch (type) {
case ISCSI_BOOT_ETH_FLAGS:
- rc = sprintf(str, "2\n");
+ rc = sprintf(str, "%d\n", BEISCSI_SYSFS_ISCSI_BOOT_FLAGS);
break;
case ISCSI_BOOT_ETH_INDEX:
rc = sprintf(str, "0\n");
--
2.7.4
next prev parent reply other threads:[~2017-10-10 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 10:48 [PATCH 00/10] be2iscsi: driver update 11.4.0.1 Jitendra Bhivare
2017-10-10 10:48 ` Jitendra Bhivare [this message]
2017-10-10 10:48 ` [PATCH 02/10] be2iscsi: Fix return value in mgmt_open_connection Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 03/10] be2iscsi: Free msi_name and disable HW intr Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 04/10] be2iscsi: Fix _modify_eq_delay buffer overflow Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 05/10] be2iscsi: Fix _get_initname " Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 06/10] be2iscsi: Modify IOCTL to fetch user configured IQN Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 07/10] be2iscsi: Add cmd to set host data Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 08/10] be2iscsi: Fix misc static analysis errors Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 09/10] be2iscsi: Remove A-circumflex character in copyright marking Jitendra Bhivare
2017-10-10 10:48 ` [PATCH 10/10] scsi: be2iscsi: Update driver version Jitendra Bhivare
2017-10-11 18:19 ` [PATCH 00/10] be2iscsi: driver update 11.4.0.1 Martin K. Petersen
2017-10-11 18:56 ` Chris Leech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507632500-26445-2-git-send-email-jitendra.bhivare@broadcom.com \
--to=jitendra.bhivare@broadcom.com \
--cc=cleech@redhat.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox