From: "Ewan D. Milne" <emilne@redhat.com>
To: "Madhani, Madhani" <himanshu.madhani@cavium.com>
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] qla2xxx: Fix sparse warnings for N2N
Date: Fri, 13 Oct 2017 08:25:22 -0400 [thread overview]
Message-ID: <1507897522.24441.87.camel@localhost.localdomain> (raw)
In-Reply-To: <20171013060821.28237-1-himanshu.madhani@cavium.com>
On Thu, 2017-10-12 at 23:08 -0700, Madhani, Madhani wrote:
> From: Himanshu Madhani <himanshu.madhani@cavium.com>
>
> Fixes following warning reported by 0-day kernel test build
>
> drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla2x00_els_dcmd2_iocb_timeout':
> drivers/scsi/qla2xxx/qla_iocb.c:2611:50: warning: format '%x' expects a matching
> 'unsigned int' argument [-Wformat=]
> "%s %d ELS Timeout, %8phC hdl=%x, portid=%06x\n",
>
> drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla2x00_els_dcmd2_sp_done':
> drivers/scsi/qla2xxx/qla_iocb.c:2634:11: warning: format '%s' expects argument of type 'char *', but argument 6 has type 'uint32_t {aka unsigned int}' [-Wformat=]
> "%s %s ELS hdl=%x, portid=%06x done %8pC\n",
> ^
> drivers/scsi/qla2xxx/qla_iocb.c:2634:35: warning: format '%x' expects argument of type 'unsigned int', but argument 8 has type 'uint8_t * {aka unsigned char *}' [-Wformat=]
> "%s %s ELS hdl=%x, portid=%06x done %8pC\n",
> ^
> drivers/scsi/qla2xxx/qla_iocb.c:2634:44: warning: format '%p' expects a matching 'void *' argument [-Wformat=]
> "%s %s %ELS %hdl=%x, %portid=%06x %done %8pC\n",
> ^
> Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
> ---
> drivers/scsi/qla2xxx/qla_iocb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index 6e57c48f8d95..0502ed7ee14e 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -2608,7 +2608,7 @@ qla2x00_els_dcmd2_iocb_timeout(void *data)
> int res;
>
> ql_dbg(ql_dbg_io + ql_dbg_disc, vha, 0x3069,
> - "%s %d ELS Timeout, %8phC hdl=%x, portid=%06x\n",
> + "%s hdl=%x ELS Timeout, %8phC portid=%06x\n",
> sp->name, sp->handle, fcport->port_name, fcport->d_id.b24);
>
> /* Abort the exchange */
> @@ -2631,7 +2631,7 @@ qla2x00_els_dcmd2_sp_done(void *ptr, int res)
> struct scsi_qla_host *vha = sp->vha;
>
> ql_dbg(ql_dbg_io + ql_dbg_disc, vha, 0x3072,
> - "%s %s ELS hdl=%x, portid=%06x done %8pC\n",
> + "%s ELS hdl=%x, portid=%06x done %8pC\n",
> sp->name, sp->handle, fcport->d_id.b24, fcport->port_name);
>
> complete(&lio->u.els_plogi.comp);
Can you please just submit a corrected v2 of your earlier patch instead
of this one?
-Ewan
next prev parent reply other threads:[~2017-10-13 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 6:08 [PATCH 1/1] qla2xxx: Fix sparse warnings for N2N Madhani, Madhani
2017-10-13 12:25 ` Ewan D. Milne [this message]
2017-10-13 14:28 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507897522.24441.87.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox