From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hare@suse.de" <hare@suse.de>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
"tom81094@gmail.com" <tom81094@gmail.com>,
"paolo.valente@linaro.org" <paolo.valente@linaro.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"osandov@fb.com" <osandov@fb.com>,
"loberman@redhat.com" <loberman@redhat.com>,
"james.smart@broadcom.com" <james.smart@broadcom.com>
Subject: Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops
Date: Mon, 16 Oct 2017 16:06:32 +0000 [thread overview]
Message-ID: <1508169991.2493.17.camel@wdc.com> (raw)
In-Reply-To: <515ca83f-5629-31e2-ef70-1869ae1b75ef@suse.de>
On Mon, 2017-10-16 at 13:30 +0200, Hannes Reinecke wrote:
> On Fri, Oct 13, 2017 at 05:08:52PM +0000, Bart Van Assche wrote:
> > (+Himanshu Madhani)
> >
> > Himanshu, do you perhaps know whether it is safe to increase cmd_per_lun for
> > the qla2xxx initiator driver to the scsi_host->can_queue value?
>
> '3' is just a starting point; later on it'll be adjusted via scsi_change_depth().
> Looks like it's not working correctly with blk-mq, though.
Hello Hannes,
Isn't the purpose of scsi_change_queue_depth() to change the sdev queue_depth
only? As far as I know there is only one assignment of shost->cmd_per_lun in
the SCSI core and that's the following assignment in scsi_host_alloc():
shost->cmd_per_lun = sht->cmd_per_lun;
Bart.
next prev parent reply other threads:[~2017-10-16 16:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 18:36 [PATCH V7 0/6] blk-mq-sched: improve sequential I/O performance Ming Lei
2017-10-12 18:36 ` [PATCH V7 1/6] blk-mq-sched: fix scheduler bad performance Ming Lei
2017-10-12 18:37 ` [PATCH V7 2/6] blk-mq-sched: move actual dispatching into one helper Ming Lei
2017-10-12 18:37 ` [PATCH V7 3/6] sbitmap: introduce __sbitmap_for_each_set() Ming Lei
2017-10-12 18:37 ` [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops Ming Lei
2017-10-12 18:46 ` Jens Axboe
2017-10-13 0:19 ` Ming Lei
2017-10-13 14:44 ` Jens Axboe
2017-10-13 16:07 ` Ming Lei
2017-10-13 16:19 ` Jens Axboe
2017-10-13 16:21 ` Ming Lei
2017-10-13 16:28 ` Jens Axboe
2017-10-13 16:31 ` Bart Van Assche
2017-10-13 16:33 ` Jens Axboe
2017-10-13 16:45 ` Ming Lei
2017-10-13 17:08 ` Bart Van Assche
2017-10-13 17:29 ` Ming Lei
2017-10-13 17:47 ` Bart Van Assche
2017-10-16 11:30 ` Hannes Reinecke
2017-10-16 16:06 ` Bart Van Assche [this message]
2017-10-17 1:29 ` Ming Lei
2017-10-17 6:38 ` Hannes Reinecke
2017-10-17 9:36 ` Ming Lei
2017-10-17 18:09 ` Bart Van Assche
2017-10-13 16:17 ` Ming Lei
2017-10-13 16:20 ` Jens Axboe
2017-10-13 16:22 ` Ming Lei
2017-10-13 16:28 ` Jens Axboe
2017-10-12 18:37 ` [PATCH V7 5/6] blk-mq-sched: improve dispatching from sw queue Ming Lei
2017-10-12 18:48 ` Bart Van Assche
2017-10-13 0:20 ` Ming Lei
2017-10-12 18:37 ` [PATCH V7 6/6] SCSI: implement .get_budget and .put_budget for blk-mq Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508169991.2493.17.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=himanshu.madhani@cavium.com \
--cc=james.smart@broadcom.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
--cc=tom81094@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).