From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "oleksandr@natalenko.name" <oleksandr@natalenko.name>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH v10 00/10] block, scsi, md: Improve suspend and resume
Date: Sat, 21 Oct 2017 17:59:37 +0000 [thread overview]
Message-ID: <1508608776.9251.6.camel@wdc.com> (raw)
In-Reply-To: <3006499.SSja2RFHbQ@natalenko.name>
On Sat, 2017-10-21 at 19:21 +0200, Oleksandr Natalenko wrote:
> I've cherry-picked this series for current upstream/master branch, and got
> this while performing another suspend try:
>
> ===
> [ 62.415890] Freezing of tasks failed after 20.007 seconds (1 tasks refusing
> to freeze, wq_busy=0):
> [ 62.421150] xfsaild/dm-7 D 0 289 2 0x80000000
> [ 62.425800] Call Trace:
> [ 62.428902] __schedule+0x239/0x870
> [ 62.431834] schedule+0x33/0x90
> [ 62.434156] _xfs_log_force+0x143/0x280 [xfs]
> [ 62.438767] ? schedule_timeout+0x188/0x390
> [ 62.443592] ? wake_up_q+0x80/0x80
> [ 62.446545] ? xfsaild+0x18d/0x780 [xfs]
> [ 62.449702] xfs_log_force+0x2c/0x90 [xfs]
> [ 62.453217] xfsaild+0x18d/0x780 [xfs]
> [ 62.456717] kthread+0x124/0x140
> [ 62.459237] ? kthread+0x124/0x140
> [ 62.461818] ? xfs_trans_ail_cursor_first+0x90/0x90 [xfs]
> [ 62.465146] ? kthread_create_on_node+0x70/0x70
> [ 62.467331] ret_from_fork+0x25/0x30
> [ 62.474386] Restarting kernel threads ... done.
> ===
Hello Oleksandr,
Thank you for having tested v10 of this patch series. This patch series only
changes the behavior of suspending devices but not the behavior of freezing
the XFS kernel threads. During suspend task freezing occurs *before*
suspending devices. In other words, the lockup occurred before the code was
reached that is modified by this patch series. So I think you ran into a bug
in the XFS code and not into a bug in this patch series.
Bart.
next prev parent reply other threads:[~2017-10-21 17:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 23:26 [PATCH v10 00/10] block, scsi, md: Improve suspend and resume Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 01/10] md: Rename md_notifier into md_reboot_notifier Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 02/10] md: Introduce md_stop_all_writes() Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 03/10] md: Neither resync nor reshape while the system is frozen Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 04/10] block: Make q_usage_counter also track legacy requests Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 05/10] block: Introduce blk_get_request_flags() Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 06/10] block: Introduce BLK_MQ_REQ_PREEMPT Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 07/10] ide, scsi: Tell the block layer at request allocation time about preempt requests Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 08/10] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 09/10] block, scsi: Make SCSI quiesce and resume work reliably Bart Van Assche
2017-10-17 23:26 ` [PATCH v10 10/10] block, nvme: Introduce blk_mq_req_flags_t Bart Van Assche
2017-10-17 23:28 ` [PATCH v10 00/10] block, scsi, md: Improve suspend and resume Jens Axboe
2017-10-17 23:40 ` Bart Van Assche
2017-10-18 1:47 ` Jens Axboe
2017-10-18 5:02 ` Oleksandr Natalenko
2017-10-18 15:27 ` Bart Van Assche
2017-10-21 17:21 ` Oleksandr Natalenko
2017-10-21 17:59 ` Bart Van Assche [this message]
2017-10-21 18:31 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508608776.9251.6.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).