From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "Himanshu.Madhani@cavium.com" <Himanshu.Madhani@cavium.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "keescook@chromium.org" <keescook@chromium.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"qla2xxx-upstream@cavium.com" <qla2xxx-upstream@cavium.com>
Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()
Date: Tue, 31 Oct 2017 18:12:27 +0000 [thread overview]
Message-ID: <1509473546.12927.5.camel@wdc.com> (raw)
In-Reply-To: <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com>
On Tue, 2017-10-31 at 18:03 +0000, Madhani, Himanshu wrote:
> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <martin.petersen@oracle.com> wrote:
> > > In preparation for unconditionally passing the struct timer_list
> > > pointer to all timer callbacks, switch to using the new timer_setup()
> > > and from_timer() to pass the timer pointer explicitly.
> >
> > Cavium folks: Please verify!
>
> I’ve checked on my setup and i am seeing regression with this patch applied.
>
> Driver load locks up the system with this patch applied.
>
> NACK
That feedback is not very helpful ...
Anyway, what kernel source tree did you use in your testing? I may be able to
free up some time to look into this myself.
Bart.
next prev parent reply other threads:[~2017-10-31 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 10:07 [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Kees Cook
2017-10-31 15:49 ` Martin K. Petersen
2017-10-31 18:03 ` Madhani, Himanshu
2017-10-31 18:12 ` Bart Van Assche [this message]
2017-10-31 18:16 ` Madhani, Himanshu
2017-10-31 18:28 ` Kees Cook
2017-10-31 18:36 ` Madhani, Himanshu
2017-10-31 18:45 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2017-10-05 0:48 Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509473546.12927.5.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Himanshu.Madhani@cavium.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).