From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"hare@suse.com" <hare@suse.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"jthumshirn@suse.de" <jthumshirn@suse.de>
Subject: Re: [PATCH] sd: Fix a disk probing hang
Date: Wed, 8 Nov 2017 16:31:34 +0000 [thread overview]
Message-ID: <1510158692.24237.11.camel@wdc.com> (raw)
In-Reply-To: <cf1f170e-3cf4-bed2-e6a9-2354748e0078@suse.com>
On Wed, 2017-11-08 at 09:12 +0100, Hannes Reinecke wrote:
> You know, this actually looks like the same issue I'm chasing with iser;
> we have a customer who regularly sees lockups during scanning.
> As it turns out, iser is calling scsi_device_del() from the RX thread.
> Which in turn needs to call async_synchronize().
> If a disk scan is running at the same time we have a nice deadlock, as
> the RX thread can't move forward before aynch_synchronize() returns,
> which it'll never do as the scan cannot complete.
> I've tried to fix that by having the async probing only waiting for that
> particular instance (look for patch 'sd: use async_probe cookie to avoid
> deadlocks'), but this wasn't greeted with much enthusiasm.
Hello Hannes,
Since I applied Roman Penyaev's patch "[PATCH 1/1] [RFC] blk-mq: fix queue
stalling on shared hctx restart" I have not been able to reproduce this hang.
I will let you know if I would run into this hang again.
Bart.
prev parent reply other threads:[~2017-11-08 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 17:38 [PATCH] sd: Fix a disk probing hang Bart Van Assche
2017-11-07 18:09 ` James Bottomley
2017-11-07 22:42 ` Bart Van Assche
2017-11-07 22:57 ` James Bottomley
2017-11-08 8:12 ` Hannes Reinecke
2017-11-08 16:31 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510158692.24237.11.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).